You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by GitBox <gi...@apache.org> on 2019/09/30 03:20:09 UTC

[GitHub] [incubator-weex] weex-bot commented on issue #2945: [iOS] Protect endless iteration when setting index for slider view.

weex-bot commented on issue #2945: [iOS] Protect endless iteration when setting index for slider view.
URL: https://github.com/apache/incubator-weex/pull/2945#issuecomment-536385198
 
 
   
   <!--
     0 failure: 
     4 warning:  No Changelog chan..., Current pr not bi..., If your PR is abo..., If you update the...
     
     
     DangerID: danger-id-danger;
   -->
   
   
   <table>
     <thead>
       <tr>
         <th width="50"></th>
         <th width="100%" data-danger-table="true">Warnings</th>
       </tr>
     </thead>
     <tbody><tr>
         <td>:warning:</td>
         <td>No Changelog changes! - <i>Can you add a Changelog? To do so,append your changes to the changelog.md</i></td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>Current pr not bind the milestone</td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: <a href='http://dotwe.org/vue'>http://dotwe.org/vue</a></td>
       </tr>
     
   <tr>
         <td>:warning:</td>
         <td>If you update the code, maybe you should update the documentation and add the documentation link in the PR description. 
   here is the guide about how to contribute documentation: <a href='https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document'>https://github.com/apache/incubator-weex/blob/master/CONTRIBUTING.md#contribute-code-or-document</a></td>
       </tr>
     </tbody>
   </table>
   
   
   
   <p align="right">
     Generated by :no_entry_sign: <a href="https://danger.systems/js">dangerJS</a> against cb7fe03233744d34849c92b1cc20be2a5a86e4a8
   </p>
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services