You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "snuyanzin (via GitHub)" <gi...@apache.org> on 2026/05/01 12:26:22 UTC
[PR] [hotfix] Add log4j-layout-template-json to NOTICE [flink]
snuyanzin opened a new pull request, #28081:
URL: https://github.com/apache/flink/pull/28081
## What is the purpose of the change
It was added at https://github.com/apache/flink/pull/25888
however was not added to NOTICE
the PR is fixing it
also it fixes deps in NOTICE, which were missed in https://github.com/apache/flink/pull/28072
## Brief change log
NOTICE
## Verifying this change
manual
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): ( no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
- The serializers: (no )
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change the checkbox below to `[X]` followed by the name of the tool, and uncomment the
"Generated-by" line. See the ASF Generative Tooling Guidance for details:
https://www.apache.org/legal/generative-tooling.html
You are responsible for the quality and correctness of every change in this PR
regardless of the tooling used. Low-effort AI-generated PRs will be closed. See
AGENTS.md for the full guidance.
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name and Version]
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Add log4j-layout-template-json to NOTICE [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #28081:
URL: https://github.com/apache/flink/pull/28081#issuecomment-4359312389
looks like historical preamble while most of others are covered by license checker these deps are not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Add log4j-layout-template-json to NOTICE [flink]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on PR #28081:
URL: https://github.com/apache/flink/pull/28081#issuecomment-4359297167
@snuyanzin Idealy the PR should have failed in we missed NOTICE. I faced multiple NOTICE related CI failure in https://github.com/apache/flink/pull/28072, this wasnt caught. Just wondering why it missed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Add log4j-layout-template-json to NOTICE [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin merged PR #28081:
URL: https://github.com/apache/flink/pull/28081
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Add log4j-layout-template-json to NOTICE [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #28081:
URL: https://github.com/apache/flink/pull/28081#issuecomment-4359256421
cc @spuru9 since you participated in https://github.com/apache/flink/pull/28072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Add log4j-layout-template-json to NOTICE [flink]
Posted by "spuru9 (via GitHub)" <gi...@apache.org>.
spuru9 commented on PR #28081:
URL: https://github.com/apache/flink/pull/28081#issuecomment-4359382691
As per Claude
NoticeFileChecker only scans module `META-INF/NOTICE` files. At `tools/ci/flink-ci-tools/.../NoticeFileChecker.java:358-368`, findNoticeFiles() walks the tree and keeps only paths ending in `…/resources/META-INF/NOTICE` — i.e., per-module shaded-jar NOTICE files inside the Maven build.
NOTICE-binary_PREAMBLE.txt doesn't match that pattern. It lives under tools/releasing/, isn't inside any module's `src/main/resources/META-INF/`, and is used by the release tooling (collect_license_files.sh etc.) to hand-assemble the binary-release NOTICE — not by CI. So the checker never looks at it, and a stale version doesn't fail the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Add log4j-layout-template-json to NOTICE [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #28081:
URL: https://github.com/apache/flink/pull/28081#issuecomment-4363512536
>Gist: Need to be updated manually when releasing.
ideally it should be updated while version update or adding a new artifact rather than while releasing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Add log4j-layout-template-json to NOTICE [flink]
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on PR #28081:
URL: https://github.com/apache/flink/pull/28081#issuecomment-4359258200
cc @ryanvanhuuksloot since you participated in https://github.com/apache/flink/pull/25888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix] Add log4j-layout-template-json to NOTICE [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #28081:
URL: https://github.com/apache/flink/pull/28081#issuecomment-4359279454
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9704fc66b5e4dbe1479bf2663316d56bfc8031be",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9704fc66b5e4dbe1479bf2663316d56bfc8031be",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9704fc66b5e4dbe1479bf2663316d56bfc8031be UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org