You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/02 13:35:09 UTC

[GitHub] [airflow] michalslowikowski00 opened a new pull request #7000: [AIRFLOW-6113] [AIP-21] Rename GCP transfer operator

michalslowikowski00 opened a new pull request #7000: [AIRFLOW-6113] [AIP-21] Rename GCP transfer operator
URL: https://github.com/apache/airflow/pull/7000
 
 
   PR contains changes regarding AIP-21 (renaming GCP operators and hooks):
   - renamed GCP modules
   - adde deprecation warnings to the contrib modules
   - fixed tests
   - updated UPDATING.md
   
   ---
   - [ ] Description above provides context of the change
   - [ ] Commit message contains [\[AIRFLOW-XXXX\]](https://issues.apache.org/jira/browse/AIRFLOW-XXXX) or `[AIRFLOW-XXXX]` for document-only changes
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] michalslowikowski00 commented on issue #7000: [AIRFLOW-6113] [AIP-21] Rename GCP transfer operator

Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on issue #7000: [AIRFLOW-6113] [AIP-21] Rename GCP transfer operator
URL: https://github.com/apache/airflow/pull/7000#issuecomment-571481187
 
 
   @nuclearpinguin <3

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #7000: [AIRFLOW-6113] [AIP-21] Rename GCP transfer operator

Posted by GitBox <gi...@apache.org>.
michalslowikowski00 commented on a change in pull request #7000: [AIRFLOW-6113] [AIP-21] Rename GCP transfer operator
URL: https://github.com/apache/airflow/pull/7000#discussion_r362754014
 
 

 ##########
 File path: airflow/gcp/operators/cloud_storage_transfer_service.py
 ##########
 @@ -218,17 +218,17 @@ def _validate_inputs(self):
 
     def execute(self, context):
         TransferJobPreprocessor(body=self.body, aws_conn_id=self.aws_conn_id).process_body()
-        hook = GCPTransferServiceHook(api_version=self.api_version, gcp_conn_id=self.gcp_conn_id)
+        hook = CloudDataTransferServiceHook(api_version=self.api_version, gcp_conn_id=self.gcp_conn_id)
         return hook.create_transfer_job(body=self.body)
 
 
-class GcpTransferServiceJobUpdateOperator(BaseOperator):
+class CloudDataTransferServiceUpdateJobOperator(BaseOperator):
     """
     Updates a transfer job that runs periodically.
 
     .. seealso::
         For more information on how to use this operator, take a look at the guide:
-        :ref:`howto/operator:GcpTransferServiceJobUpdateOperator`
+        :ref:`howto/operator:CloudDataTransferServiceUpdateJobOperator`
 
 Review comment:
   Commit with all fixes is on the way. I just finished fixing the PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] nuclearpinguin merged pull request #7000: [AIRFLOW-6113] [AIP-21] Rename GCP transfer operator

Posted by GitBox <gi...@apache.org>.
nuclearpinguin merged pull request #7000: [AIRFLOW-6113] [AIP-21] Rename GCP transfer operator
URL: https://github.com/apache/airflow/pull/7000
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] nuclearpinguin commented on a change in pull request #7000: [AIRFLOW-6113] [AIP-21] Rename GCP transfer operator

Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on a change in pull request #7000: [AIRFLOW-6113] [AIP-21] Rename GCP transfer operator
URL: https://github.com/apache/airflow/pull/7000#discussion_r362734524
 
 

 ##########
 File path: airflow/gcp/operators/cloud_storage_transfer_service.py
 ##########
 @@ -218,17 +218,17 @@ def _validate_inputs(self):
 
     def execute(self, context):
         TransferJobPreprocessor(body=self.body, aws_conn_id=self.aws_conn_id).process_body()
-        hook = GCPTransferServiceHook(api_version=self.api_version, gcp_conn_id=self.gcp_conn_id)
+        hook = CloudDataTransferServiceHook(api_version=self.api_version, gcp_conn_id=self.gcp_conn_id)
         return hook.create_transfer_job(body=self.body)
 
 
-class GcpTransferServiceJobUpdateOperator(BaseOperator):
+class CloudDataTransferServiceUpdateJobOperator(BaseOperator):
     """
     Updates a transfer job that runs periodically.
 
     .. seealso::
         For more information on how to use this operator, take a look at the guide:
-        :ref:`howto/operator:GcpTransferServiceJobUpdateOperator`
+        :ref:`howto/operator:CloudDataTransferServiceUpdateJobOperator`
 
 Review comment:
   Have you also changed the docs? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services