You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "pvary (via GitHub)" <gi...@apache.org> on 2023/04/20 14:55:40 UTC

[GitHub] [flink] pvary opened a new pull request, #22437: [FLINK-31868] Fix DefaultInputSplitAssigner javadoc for class

pvary opened a new pull request, #22437:
URL: https://github.com/apache/flink/pull/22437

   ## What is the purpose of the change
   
   Fix the discrepancy between the code and the comment. The comment erroneously states that the return order for the splits is in order.
   
   ## Brief change log
   
   The decision was to update the comment
   
   ## Verifying this change
   
   No testing is needed
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? JavaDocs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] pvary commented on pull request #22437: [FLINK-31868] Fix DefaultInputSplitAssigner javadoc for class

Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on PR #22437:
URL: https://github.com/apache/flink/pull/22437#issuecomment-1517549223

   Thanks @zhuzhurk for the guidance and commit!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhuzhurk closed pull request #22437: [FLINK-31868] Fix DefaultInputSplitAssigner javadoc for class

Posted by "zhuzhurk (via GitHub)" <gi...@apache.org>.
zhuzhurk closed pull request #22437: [FLINK-31868] Fix DefaultInputSplitAssigner javadoc for class
URL: https://github.com/apache/flink/pull/22437


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #22437: [FLINK-31868] Fix DefaultInputSplitAssigner javadoc for class

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22437:
URL: https://github.com/apache/flink/pull/22437#issuecomment-1516491821

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "21efa11e1caf20bc43f19f9a662064fb7cbe5926",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "21efa11e1caf20bc43f19f9a662064fb7cbe5926",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 21efa11e1caf20bc43f19f9a662064fb7cbe5926 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org