You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/10/27 03:09:23 UTC

[GitHub] [druid] vogievetsky opened a new pull request #10533: Web console: improve make type preservation in ingestion configs in the data loader

vogievetsky opened a new pull request #10533:
URL: https://github.com/apache/druid/pull/10533


   This PR fixes an issue that in the data loader if you toggle the rollup it loses any previously entered type information because it will simply rescan the sample. It makes a couple of other fixes also.
   This work was done as a result of 2 user studies where people loaded data into Druid via the data loader and then user a couple of other parts of the console.
   
   This PR also refactors all the druid concepts into the `druid-modals` directory and breaks them up a bit so they are not just huge files (bad code smell).
   
   In addition to that this PR also:
   - Adds a `Partitioning` column (derived from `shardSpec`) to the segment view (see screenshot)
   - Adds a `Segment granularity` column to the datasource view (see screenshot)
   - Creates a framework where auto form fields could be used to verify the modal reducing redundancy
   - Adds an optional validator prop to the `JsonInput` to let it surface higher level errors
   - Allows for using a `__time` transform in the parse time step of the data loader
   - Fixes the issue the it was not possible to edit the `tuningConfig.partitionsSpec.type` from the `Edit spec` step of the data loader
   - Adds `oneOf` utility function to make `AutoForm` definitions more succinct 
   - Fixes the height of the icons in the data loader splash screen so it does not bounce
   - Uses the improved escaping from druid-query-toolkit to make data view tables' filtering better
   - Fixes some typos
   
   ### Partitioning column
   
   ![image](https://user-images.githubusercontent.com/177816/97240597-ebedaa80-17ab-11eb-976f-a0d49d6d1a40.png)
   
   ### Segment granularity column
   
   ![image](https://user-images.githubusercontent.com/177816/97240667-1b9cb280-17ac-11eb-9c55-e312c24cd8fc.png)
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org