You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Neil Prosser (JIRA)" <ji...@apache.org> on 2011/08/18 01:04:27 UTC
[jira] [Updated] (SOLR-2716) QueryResultKey hashCode() and equals()
is dependent on filter order
[ https://issues.apache.org/jira/browse/SOLR-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Neil Prosser updated SOLR-2716:
-------------------------------
Description:
The hashCode() and equals() methods of a QueryResultKey are dependent on the order of the filters meaning that potentially identical result sets are missed when cached.
Query query = new TermQuery(new Term("field1", "value1"));
Query filter1 = new TermQuery(new Term("field2", "value2"));
Query filter2 = new TermQuery(new Term("field3", "value3"));
List<Query> filters1 = new ArrayList<Query>();
filters1.add(filter1);
filters1.add(filter2);
List<Query> filters2 = new ArrayList<Query>();
filters2.add(filter2);
filters2.add(filter1);
QueryResultKey key1 = new QueryResultKey(query, filters1, null, 0);
QueryResultKey key2 = new QueryResultKey(query, filters2, null, 0);
// Both the following assertions fail
assert key1.equals(key2);
assert key1.hashCode() == key2.hashCode();
was:
The hashCode() and equals() methods of a QueryResultKey are dependent on the order of the filters meaning that potentially identical result sets are missed when cached.
{{Query query = new TermQuery(new Term("field1", "value1"));
Query filter1 = new TermQuery(new Term("field2", "value2"));
Query filter2 = new TermQuery(new Term("field3", "value3"));
List<Query> filters1 = new ArrayList<Query>();
filters1.add(filter1);
filters1.add(filter2);
List<Query> filters2 = new ArrayList<Query>();
filters2.add(filter2);
filters2.add(filter1);
QueryResultKey key1 = new QueryResultKey(query, filters1, null, 0);
QueryResultKey key2 = new QueryResultKey(query, filters2, null, 0);
// Both the following assertions fail
assert key1.equals(key2);
assert key1.hashCode() == key2.hashCode();}}
> QueryResultKey hashCode() and equals() is dependent on filter order
> -------------------------------------------------------------------
>
> Key: SOLR-2716
> URL: https://issues.apache.org/jira/browse/SOLR-2716
> Project: Solr
> Issue Type: Improvement
> Components: search
> Affects Versions: 3.3
> Reporter: Neil Prosser
> Priority: Minor
>
> The hashCode() and equals() methods of a QueryResultKey are dependent on the order of the filters meaning that potentially identical result sets are missed when cached.
> Query query = new TermQuery(new Term("field1", "value1"));
> Query filter1 = new TermQuery(new Term("field2", "value2"));
> Query filter2 = new TermQuery(new Term("field3", "value3"));
> List<Query> filters1 = new ArrayList<Query>();
> filters1.add(filter1);
> filters1.add(filter2);
> List<Query> filters2 = new ArrayList<Query>();
> filters2.add(filter2);
> filters2.add(filter1);
> QueryResultKey key1 = new QueryResultKey(query, filters1, null, 0);
> QueryResultKey key2 = new QueryResultKey(query, filters2, null, 0);
> // Both the following assertions fail
> assert key1.equals(key2);
> assert key1.hashCode() == key2.hashCode();
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org