You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/04/01 06:02:13 UTC
[GitHub] [calcite] danny0405 commented on a change in pull request #1141:
[CALCITE-2914] Improve how LatticeSuggester deduces foreign keys
danny0405 commented on a change in pull request #1141: [CALCITE-2914] Improve how LatticeSuggester deduces foreign keys
URL: https://github.com/apache/calcite/pull/1141#discussion_r270724081
##########
File path: core/src/main/codegen/templates/Parser.jj
##########
@@ -5652,6 +5652,24 @@ SqlCall withinGroup(SqlNode arg) :
}
}
+SqlCall nullTreatment(SqlCall arg) :
+{
+ final Span span;
+}
+{
+ (
+ <IGNORE> { span = span(); } <NULLS> {
+ return SqlStdOperatorTable.IGNORE_NULLS.createCall(
+ span.end(this), arg);
+ }
+ |
+ <RESPECT> { span = span(); } <NULLS> {
+ return SqlStdOperatorTable.RESPECT_NULLS.createCall(
+ span.end(this), arg);
+ }
+ )
+}
+
Review comment:
Yes, multiple PRS are here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services