[GitHub] [guacamole-client] mike-jumper commented on a change in pull request #519: GUACAMOLE-728: Implement EnumGuacamoleProperty.

[GitBox <gi...@apache.org>]

mike-jumper commented on a change in pull request #519:
URL: https://github.com/apache/guacamole-client/pull/519#discussion_r439190984



##########
File path: extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/conf/RadiusAuthenticationProtocol.java
##########
@@ -19,100 +19,54 @@
 
 package org.apache.guacamole.auth.radius.conf;
 
+import org.apache.guacamole.properties.EnumGuacamoleProperty.PropertyValue;
+
 /**
  * This enum represents supported RADIUS authentication protocols for
  * the guacamole-auth-radius extension.
  */
 public enum RadiusAuthenticationProtocol {
     
     /**
-     * Password Authentication Protocol (PAP)
+     * Password Authentication Protocol (PAP).
      */
-    PAP("pap"),
+    @PropertyValue("pap")
+    PAP,
     
     /**
-     * Challenge-Handshake Authentication Protocol (CHAP)
+     * Challenge-Handshake Authentication Protocol (CHAP).
      */
-    CHAP("chap"),
+    @PropertyValue("chap")
+    CHAP,
     
     /**
-     * Microsoft implementation of CHAP, Version 1 (MS-CHAPv1)
+     * Microsoft implementation of CHAP, Version 1 (MS-CHAPv1).
      */
-    MSCHAPv1("mschapv1"),
+    @PropertyValue("mschapv1")
+    MSCHAP_V1,
     
     /**
-     * Microsoft implementation of CHAP, Version 2 (MS-CHAPv2)
+     * Microsoft implementation of CHAP, Version 2 (MS-CHAPv2).
      */
-    MSCHAPv2("mschapv2"),
+    @PropertyValue("mschapv2")
+    MSCHAP_V2,
     
     /**
-     * Extensible Authentication Protocol (EAP) with MD5 Hashing (EAP-MD5)
+     * Extensible Authentication Protocol (EAP) with MD5 Hashing (EAP-MD5).
      */
-    EAP_MD5("eap-md5"),
+    @PropertyValue("eap-md5")
+    EAP_MD5,
 
     /**
      * Extensible Authentication Protocol (EAP) with TLS encryption (EAP-TLS).
      */
-    EAP_TLS("eap-tls"),
+    @PropertyValue("eap-tls")
+    EAP_TLS,
 
     /**
      * Extensible Authentication Protocol (EAP) with Tunneled TLS (EAP-TTLS).
      */
-    EAP_TTLS("eap-ttls");
+    @PropertyValue("eap-ttls")
+    EAP_TTLS;
 
-    /**
-     * This variable stores the string value of the protocol, and is also
-     * used within the extension to pass to JRadius for configuring the
-     * library to talk to the RADIUS server.
-     */
-    private final String strValue;
-    
-    /**
-     * Create a new RadiusAuthenticationProtocol object having the
-     * given string value.
-     * 
-     * @param strValue
-     *     The value of the protocol to store as a string, which will be used
-     *     in specifying the protocol within the guacamole.properties file, and
-     *     will also be used by the JRadius library for its configuration.

Review comment:
       Eep - will deleting this break RADIUS? I don't recall the string value being used for JRadius, but if that's the case, I should definitely put some of this back.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org