You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by toddleo <gi...@git.apache.org> on 2017/09/07 07:03:01 UTC

[GitHub] spark pull request #8676: [SPARK-9078] [SQL] Allow jdbc dialects to override...

Github user toddleo commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8676#discussion_r137460965
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala ---
    @@ -88,6 +88,17 @@ abstract class JdbcDialect {
       def quoteIdentifier(colName: String): String = {
         s""""$colName""""
       }
    +
    +  /**
    +   * Get the SQL query that should be used to find if the given table exists. Dialects can
    +   * override this method to return a query that works best in a particular database.
    +   * @param table  The name of the table.
    +   * @return The SQL query to use for checking the table.
    +   */
    +  def getTableExistsQuery(table: String): String = {
    +    s"SELECT * FROM $table WHERE 1=0"
    --- End diff --
    
    What's the specific reason table name is not quoted? We happen to have a table with dots and parenthesis in its name, planning to add surrounding backticks before passing it to Spark.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org