You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/07/29 02:00:29 UTC
[GitHub] [iceberg] hililiwei opened a new pull request, #5380: Docs: Flink `Streaming upsert write`
hililiwei opened a new pull request, #5380:
URL: https://github.com/apache/iceberg/pull/5380
Add upsert content to FLink doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on a diff in pull request #5380: Docs: Flink `Streaming upsert write`
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on code in PR #5380:
URL: https://github.com/apache/iceberg/pull/5380#discussion_r944072136
##########
docs/flink-getting-started.md:
##########
@@ -634,6 +634,26 @@ FlinkSink.forRowData(input)
env.execute("Test Iceberg DataStream");
```
+## UPSERT mode
+
+Iceberg supports `UPSERT` based on the primary key when writing data into v2 table format.
Review Comment:
Here, mention `There are two ways to enable upsert`. the following two parts can be labeled as `1.` and `2.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on a diff in pull request #5380: Docs: Flink `Streaming upsert write`
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on code in PR #5380:
URL: https://github.com/apache/iceberg/pull/5380#discussion_r944071871
##########
docs/flink-getting-started.md:
##########
@@ -634,6 +634,26 @@ FlinkSink.forRowData(input)
env.execute("Test Iceberg DataStream");
```
+## UPSERT mode
+
+Iceberg supports `UPSERT` based on the primary key when writing data into v2 table format.
+
+Enable the `UPSERT` mode on a table by adding the `write.upsert.enabled` configuration. All writing will be in `UPSERT` mode unless you overwrite it when building the writer:
Review Comment:
> All writing will be in `UPSERT` mode unless you overwrite it when building the writer:
This part is not completed. "building the writer" is not followed by example. I would actually suggest remove this part. Instead, you can follow up with the previous sentence as "Here is an example create table SQL statement with upsert table property".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on a diff in pull request #5380: Docs: Flink `Streaming upsert write`
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on code in PR #5380:
URL: https://github.com/apache/iceberg/pull/5380#discussion_r944074285
##########
docs/flink-getting-started.md:
##########
@@ -634,6 +634,26 @@ FlinkSink.forRowData(input)
env.execute("Test Iceberg DataStream");
```
+## UPSERT mode
+
+Iceberg supports `UPSERT` based on the primary key when writing data into v2 table format.
+
+Enable the `UPSERT` mode on a table by adding the `write.upsert.enabled` configuration. All writing will be in `UPSERT` mode unless you overwrite it when building the writer:
Review Comment:
Lead this paragraph with `1. `. e.g.,
```
1. Enable the `UPSERT` mode as as table-level property ..... Here is an example SQL statement to set the table property when creating a table. It would be applied for all write paths to this table (batch or streaming) unless overwritten by write options as described later.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] hililiwei commented on pull request #5380: Docs: Flink `Streaming upsert write`
Posted by GitBox <gi...@apache.org>.
hililiwei commented on PR #5380:
URL: https://github.com/apache/iceberg/pull/5380#issuecomment-1213833114
I added upsert to the sql and stream sections respectively and modified according to the comments. @stevenzwu
thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on a diff in pull request #5380: Docs: Flink `Streaming upsert write`
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on code in PR #5380:
URL: https://github.com/apache/iceberg/pull/5380#discussion_r944072440
##########
docs/flink-getting-started.md:
##########
@@ -634,6 +634,26 @@ FlinkSink.forRowData(input)
env.execute("Test Iceberg DataStream");
```
+## UPSERT mode
+
+Iceberg supports `UPSERT` based on the primary key when writing data into v2 table format.
+
+Enable the `UPSERT` mode on a table by adding the `write.upsert.enabled` configuration. All writing will be in `UPSERT` mode unless you overwrite it when building the writer:
+
+```
+CREATE TABLE `hive_catalog`.`default`.`sample` (
+ `id` INT UNIQUE COMMENT 'unique id',
+ `data` STRING NOT NULL,
+ PRIMARY KEY(`id`) NOT ENFORCED
+) with ('format-version'='2', 'write.upsert.enabled'='true');
+```
+
+Enabling `UPSERT` mode using `upsert-enabled` in the [write options](#Write options) provides more flexibility than when creating a table. Note that you still need to use v2 table format and specify the primary key when creating the table.
Review Comment:
Lead the paragraph with `2.`
Maybe follow up with a small code snippet like the SQL above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #5380: Docs: Flink `Streaming upsert write`
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #5380:
URL: https://github.com/apache/iceberg/pull/5380#discussion_r939734469
##########
docs/flink-getting-started.md:
##########
@@ -551,6 +551,37 @@ FlinkSink.forRowData(input)
env.execute("Test Iceberg DataStream");
```
+### Streaming upsert write
+Iceberg supports upsert based on the primary key when writing streaming data into v2 table format.
+
+You can enable `upsert` in the following way:
+
+* Create an UPSERT Table
Review Comment:
What does this mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on a diff in pull request #5380: Docs: Flink `Streaming upsert write`
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on code in PR #5380:
URL: https://github.com/apache/iceberg/pull/5380#discussion_r941785000
##########
docs/flink-getting-started.md:
##########
@@ -634,6 +634,26 @@ FlinkSink.forRowData(input)
env.execute("Test Iceberg DataStream");
```
+### Streaming upsert write
Review Comment:
is upsert streaming only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on a diff in pull request #5380: Docs: Flink `Streaming upsert write`
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on code in PR #5380:
URL: https://github.com/apache/iceberg/pull/5380#discussion_r941796654
##########
docs/flink-getting-started.md:
##########
@@ -634,6 +634,26 @@ FlinkSink.forRowData(input)
env.execute("Test Iceberg DataStream");
```
+### Streaming upsert write
+
+Iceberg supports `UPSERT` based on the primary key when writing streaming data into v2 table format. To enable it, create an `UPSERT` table or configuration it when building a writer.
+
+For an `UPSERT` table, all writing will be in `UPSERT` mode unless you overwrite it when building the writer:
+
+```
+CREATE TABLE `hive_catalog`.`default`.`sample` (
+ `id` INT UNIQUE COMMENT 'unique id',
+ `data` STRING NOT NULL,
+ PRIMARY KEY(`id`) NOT ENFORCED
+) with ('format-version'='2', 'write.upsert.enabled'='true');
+```
+
+Enabling `UPSERT` using `upsert-enabled` in the [write options](#Write options) provides more flexibility than when creating a table. Note that you still need to use v2 table format and specify the primary key when creating the table.
+
+{{< hint info >}}
+OVERWRITE mode shouldn't be enable when configuring to use UPSERT data stream. In UPSERT mode, if the table is partitioned, the partition fields should be a part of equality fields.
Review Comment:
nit: `should be a part of equality fields` -> `should be included in equality fields`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] hililiwei commented on a diff in pull request #5380: Docs: Flink `Streaming upsert write`
Posted by GitBox <gi...@apache.org>.
hililiwei commented on code in PR #5380:
URL: https://github.com/apache/iceberg/pull/5380#discussion_r945092357
##########
docs/flink-getting-started.md:
##########
@@ -634,6 +634,26 @@ FlinkSink.forRowData(input)
env.execute("Test Iceberg DataStream");
```
+### Streaming upsert write
+
+Iceberg supports `UPSERT` based on the primary key when writing streaming data into v2 table format. To enable it, create an `UPSERT` table or configuration it when building a writer.
+
+For an `UPSERT` table, all writing will be in `UPSERT` mode unless you overwrite it when building the writer:
+
+```
+CREATE TABLE `hive_catalog`.`default`.`sample` (
Review Comment:
I added upsert doc to the sql and stream sections respectively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on a diff in pull request #5380: Docs: Flink `Streaming upsert write`
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on code in PR #5380:
URL: https://github.com/apache/iceberg/pull/5380#discussion_r941796023
##########
docs/flink-getting-started.md:
##########
@@ -634,6 +634,26 @@ FlinkSink.forRowData(input)
env.execute("Test Iceberg DataStream");
```
+### Streaming upsert write
+
+Iceberg supports `UPSERT` based on the primary key when writing streaming data into v2 table format. To enable it, create an `UPSERT` table or configuration it when building a writer.
+
+For an `UPSERT` table, all writing will be in `UPSERT` mode unless you overwrite it when building the writer:
+
+```
+CREATE TABLE `hive_catalog`.`default`.`sample` (
+ `id` INT UNIQUE COMMENT 'unique id',
+ `data` STRING NOT NULL,
+ PRIMARY KEY(`id`) NOT ENFORCED
+) with ('format-version'='2', 'write.upsert.enabled'='true');
+```
+
+Enabling `UPSERT` using `upsert-enabled` in the [write options](#Write options) provides more flexibility than when creating a table. Note that you still need to use v2 table format and specify the primary key when creating the table.
+
+{{< hint info >}}
+OVERWRITE mode shouldn't be enable when configuring to use UPSERT data stream. In UPSERT mode, if the table is partitioned, the partition fields should be a part of equality fields.
Review Comment:
nit:
`OVERWRITE mode shouldn't be enable when configuring to use UPSERT data stream`
->
`OVERWRITE and UPSERT can't be set together`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on a diff in pull request #5380: Docs: Flink `Streaming upsert write`
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on code in PR #5380:
URL: https://github.com/apache/iceberg/pull/5380#discussion_r944074625
##########
docs/flink-getting-started.md:
##########
@@ -634,6 +634,26 @@ FlinkSink.forRowData(input)
env.execute("Test Iceberg DataStream");
```
+## UPSERT mode
+
+Iceberg supports `UPSERT` based on the primary key when writing data into v2 table format.
+
+Enable the `UPSERT` mode on a table by adding the `write.upsert.enabled` configuration. All writing will be in `UPSERT` mode unless you overwrite it when building the writer:
+
+```
+CREATE TABLE `hive_catalog`.`default`.`sample` (
+ `id` INT UNIQUE COMMENT 'unique id',
+ `data` STRING NOT NULL,
+ PRIMARY KEY(`id`) NOT ENFORCED
+) with ('format-version'='2', 'write.upsert.enabled'='true');
+```
+
+Enabling `UPSERT` mode using `upsert-enabled` in the [write options](#Write options) provides more flexibility than when creating a table. Note that you still need to use v2 table format and specify the primary key when creating the table.
Review Comment:
this might be a little more accurate
```
provides more flexibility than when creating a table
```
--->
```
provides more flexibility than a table level config.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on a diff in pull request #5380: Docs: Flink `Streaming upsert write`
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on code in PR #5380:
URL: https://github.com/apache/iceberg/pull/5380#discussion_r944070348
##########
docs/flink-getting-started.md:
##########
@@ -634,6 +634,26 @@ FlinkSink.forRowData(input)
env.execute("Test Iceberg DataStream");
```
+## UPSERT mode
Review Comment:
I feel it is better to put it in the same level of `###` as other two write modes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on a diff in pull request #5380: Docs: Flink `Streaming upsert write`
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on code in PR #5380:
URL: https://github.com/apache/iceberg/pull/5380#discussion_r941793316
##########
docs/flink-getting-started.md:
##########
@@ -634,6 +634,26 @@ FlinkSink.forRowData(input)
env.execute("Test Iceberg DataStream");
```
+### Streaming upsert write
+
+Iceberg supports `UPSERT` based on the primary key when writing streaming data into v2 table format. To enable it, create an `UPSERT` table or configuration it when building a writer.
Review Comment:
it is probably confusing to call it `UPSERT table`. It seems to me that the essence of this part is that there are two ways to enable upsert, which is already covered the `Write options` section below.
##########
docs/flink-getting-started.md:
##########
@@ -634,6 +634,26 @@ FlinkSink.forRowData(input)
env.execute("Test Iceberg DataStream");
```
+### Streaming upsert write
+
+Iceberg supports `UPSERT` based on the primary key when writing streaming data into v2 table format. To enable it, create an `UPSERT` table or configuration it when building a writer.
+
+For an `UPSERT` table, all writing will be in `UPSERT` mode unless you overwrite it when building the writer:
+
+```
+CREATE TABLE `hive_catalog`.`default`.`sample` (
Review Comment:
If we want to be consistent with the other two sub sections `append` and `overwrite` just before this, the example should be DataStream code snippet to set the upsert write option. SQL is in a separate section somewhere above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pvary merged pull request #5380: Docs: Flink `Streaming upsert write`
Posted by GitBox <gi...@apache.org>.
pvary merged PR #5380:
URL: https://github.com/apache/iceberg/pull/5380
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] hililiwei commented on pull request #5380: Docs: Flink `Streaming upsert write`
Posted by GitBox <gi...@apache.org>.
hililiwei commented on PR #5380:
URL: https://github.com/apache/iceberg/pull/5380#issuecomment-1211653914
@stevenzwu Thank you for your review. I listed the Upsert part separately and made some changes. Please take another look. thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] stevenzwu commented on a diff in pull request #5380: Docs: Flink `Streaming upsert write`
Posted by GitBox <gi...@apache.org>.
stevenzwu commented on code in PR #5380:
URL: https://github.com/apache/iceberg/pull/5380#discussion_r944074625
##########
docs/flink-getting-started.md:
##########
@@ -634,6 +634,26 @@ FlinkSink.forRowData(input)
env.execute("Test Iceberg DataStream");
```
+## UPSERT mode
+
+Iceberg supports `UPSERT` based on the primary key when writing data into v2 table format.
+
+Enable the `UPSERT` mode on a table by adding the `write.upsert.enabled` configuration. All writing will be in `UPSERT` mode unless you overwrite it when building the writer:
+
+```
+CREATE TABLE `hive_catalog`.`default`.`sample` (
+ `id` INT UNIQUE COMMENT 'unique id',
+ `data` STRING NOT NULL,
+ PRIMARY KEY(`id`) NOT ENFORCED
+) with ('format-version'='2', 'write.upsert.enabled'='true');
+```
+
+Enabling `UPSERT` mode using `upsert-enabled` in the [write options](#Write options) provides more flexibility than when creating a table. Note that you still need to use v2 table format and specify the primary key when creating the table.
Review Comment:
this might be a little more accurate, because we can also set table property via `alter table`. it doesn't have to be `creating a table`.
```
provides more flexibility than when creating a table
```
--->
```
provides more flexibility than a table level config.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] pvary commented on pull request #5380: Docs: Flink `Streaming upsert write`
Posted by GitBox <gi...@apache.org>.
pvary commented on PR #5380:
URL: https://github.com/apache/iceberg/pull/5380#issuecomment-1223571868
Thanks @hililiwei for the PR and Ryan and @stevenzwu for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #5380: Docs: Flink `Streaming upsert write`
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #5380:
URL: https://github.com/apache/iceberg/pull/5380#discussion_r939734520
##########
docs/flink-getting-started.md:
##########
@@ -551,6 +551,37 @@ FlinkSink.forRowData(input)
env.execute("Test Iceberg DataStream");
```
+### Streaming upsert write
+Iceberg supports upsert based on the primary key when writing streaming data into v2 table format.
+
+You can enable `upsert` in the following way:
+
+* Create an UPSERT Table
Review Comment:
Oh, I see. It looks like you're trying to list options. To me, this is just confusing. I'd handle it in text rather than using bullets in a list so far apart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a diff in pull request #5380: Docs: Flink `Streaming upsert write`
Posted by GitBox <gi...@apache.org>.
rdblue commented on code in PR #5380:
URL: https://github.com/apache/iceberg/pull/5380#discussion_r939734439
##########
docs/flink-getting-started.md:
##########
@@ -551,6 +551,37 @@ FlinkSink.forRowData(input)
env.execute("Test Iceberg DataStream");
```
+### Streaming upsert write
+Iceberg supports upsert based on the primary key when writing streaming data into v2 table format.
Review Comment:
Style: there should be an empty newline following headings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org