You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/07/02 14:41:34 UTC

[GitHub] [hive] ashish-kumar-sharma commented on a change in pull request #1844: HIVE-24609: fix ArrayIndexOutOfBoundsException when position<0

ashish-kumar-sharma commented on a change in pull request #1844:
URL: https://github.com/apache/hive/pull/1844#discussion_r663063144



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java
##########
@@ -1629,6 +1629,9 @@ private boolean checkShuffleSizeForLargeTable(JoinOperator joinOp, int position,
       // Max is disabled, we can safely return false
       return false;
     }
+    if(position < 0){

Review comment:
       @lijufeng2016 Please reopen the PR. Also add a UTs and qtest




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org