You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2022/03/15 14:20:24 UTC

[GitHub] [incubator-heron] nicknezis commented on a change in pull request #3793: Add a initialization toggle to the Helm chart #3771

nicknezis commented on a change in pull request #3793:
URL: https://github.com/apache/incubator-heron/pull/3793#discussion_r826587051



##########
File path: deploy/kubernetes/helm/templates/bookie.yaml
##########
@@ -112,8 +112,9 @@ spec:
                       values:
                         - {{ .Release.Name }}-bookkeeper
                 topologyKey: "kubernetes.io/hostname"
-{{- end }}

Review comment:
       Why did the `{{- end }}` move from line 115 to 150?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@heron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org