[GitHub] [roller] mbien opened a new pull request #34: Apache Lucene Renovation

[GitBox <gi...@apache.org>]

mbien opened a new pull request #34: Apache Lucene Renovation
URL: https://github.com/apache/roller/pull/34
 
 
   Hello!
   
   updated apache lucene from 4.x to 8.1.x which required some code changes. Since lucene can only read indexes which are not older than 1-2 major versions (according to the exception i got), I added a simple check which causes a rebuild task if the index is unreadable. (first commit)
   
   The second commit removes usages of the deprecated RAMDirectory. I decided to not migrate it to MMapDirectory because the code path isn't used anywhere (or tested). Furthermore: MMapDirectory extends FSDirectory (which is currently used), so it wouldn't use the old code in any case.
   
   tests are green and i also deployed a build to my blog and tested the index rebuilding once.
   
   - - - - 
   the only change i am not sure about is: https://github.com/apache/roller/compare/master...mbien:master#diff-afa10aab8f67b8be187418bf4264950dR140
   
   Since the search results are sorted by pubdate, lucene 8 wants this field to be a DocValue of type SORTED instead of NONE and throws a IllegalStateException. So i changed it to SortedDocValuesField which made lucene happy. This field type does not have the stored yes/no property which the StringField had. Javadoc recommends to add another StoredField if storage is required - I just don't know if its needed for roller so I left it out.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services