You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by ah...@apache.org on 2017/01/05 02:14:23 UTC
zeppelin git commit: [MINOR] Fix broken CSS for plain text paragraph
result
Repository: zeppelin
Updated Branches:
refs/heads/master 9b430de18 -> ae35ec337
[MINOR] Fix broken CSS for plain text paragraph result
### What is this PR for?
After #1711 merged, plain text paragraph result CSS is broken now. Originally the text result like below (it's `0.6.2`). The font was `Monaco` applied by `.paragraph .text` class.
<img width="213" alt="screen shot 2016-12-29 at 2 58 14 pm" src="https://cloud.githubusercontent.com/assets/10060731/21538419/44d4f0e6-cde0-11e6-9707-227ee4b95446.png">
But now bootstrap default font `Helvetica` is used.
<img width="245" alt="screen shot 2016-12-29 at 2 58 07 pm" src="https://cloud.githubusercontent.com/assets/10060731/21538424/49824ec2-cde0-11e6-8a07-c893eb31a12e.png">
So I bring it back by adding new class `.plainTextContainer`.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
No Jira issue for this
### How should this be tested?
1. See the current text paragraph result (e.g. Zeppelin tutorial: Spark)
2. Apply this patch and start dev mode under `zeppelin-web` \w `npm run dev` -> browse `http://localhost:9000`
3. Compare the text paragraph result
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: AhyoungRyu <fb...@hanmail.net>
Closes #1816 from AhyoungRyu/fix/brokenCSS and squashes the following commits:
de10ec1 [AhyoungRyu] Fix broken CSS for plain text paragraph result
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/ae35ec33
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/ae35ec33
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/ae35ec33
Branch: refs/heads/master
Commit: ae35ec337618266047da27003ce55b0445bd4722
Parents: 9b430de
Author: AhyoungRyu <fb...@hanmail.net>
Authored: Thu Dec 29 15:40:13 2016 +0900
Committer: ahyoungryu <ah...@apache.org>
Committed: Thu Jan 5 11:14:19 2017 +0900
----------------------------------------------------------------------
zeppelin-web/src/app/notebook/paragraph/paragraph.css | 5 +++++
zeppelin-web/src/app/notebook/paragraph/result/result.html | 3 ++-
2 files changed, 7 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/ae35ec33/zeppelin-web/src/app/notebook/paragraph/paragraph.css
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.css b/zeppelin-web/src/app/notebook/paragraph/paragraph.css
index 70013fe..d71cdbd 100644
--- a/zeppelin-web/src/app/notebook/paragraph/paragraph.css
+++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.css
@@ -67,6 +67,11 @@ table.dataTable.table-condensed .sorting_desc:after {
right: 12px;
}
+.plainTextContainer {
+ font-family: "Monaco","Menlo","Ubuntu Mono","Consolas","source-code-pro",monospace;
+ font-size: 12px !important;
+}
+
.graphContainer {
position: relative;
margin-bottom: 5px;
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/ae35ec33/zeppelin-web/src/app/notebook/paragraph/result/result.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/paragraph/result/result.html b/zeppelin-web/src/app/notebook/paragraph/result/result.html
index feb0036..7480a7c 100644
--- a/zeppelin-web/src/app/notebook/paragraph/result/result.html
+++ b/zeppelin-web/src/app/notebook/paragraph/result/result.html
@@ -52,7 +52,8 @@ limitations under the License.
</div>
<div id="p{{id}}_text"
- ng-if="type == 'TEXT'">
+ ng-if="type == 'TEXT'"
+ class="plainTextContainer">
<div class="fa fa-level-down scroll-paragraph-down"
ng-show="showScrollDownIcon()"
ng-click="scrollParagraphDown()"