You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2018/08/23 22:02:23 UTC
[GitHub] activemq-artemis pull request #2263: ARTEMIS-2051 add trace logging for JDBC
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/2263
ARTEMIS-2051 add trace logging for JDBC
Activate by enabling TRACE logging for:
org.apache.activemq.artemis.jdbc.store.drivers.AbstractJDBCDriver
This doesn't log *all* JDBC operations, just those that are used by the
JDBC store.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-2051
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/2263.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2263
----
commit 97b26085ef5d5ef4fe89adeeaf0e1dd601af1031
Author: Justin Bertram <jb...@...>
Date: 2018-08-23T03:10:37Z
ARTEMIS-2051 add trace logging for JDBC
Activate by enabling TRACE logging for:
org.apache.activemq.artemis.jdbc.store.drivers.AbstractJDBCDriver
This doesn't log *all* JDBC operations, just those that are used by the
JDBC store.
----
---
[GitHub] activemq-artemis pull request #2263: ARTEMIS-2051 add trace logging for JDBC
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/2263
---
[GitHub] activemq-artemis pull request #2263: ARTEMIS-2051 add trace logging for JDBC
Posted by michaelandrepearce <gi...@git.apache.org>.
Github user michaelandrepearce commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/2263#discussion_r212477311
--- Diff: artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java ---
@@ -132,6 +142,11 @@ private void connect() throws SQLException {
}
final Driver dbDriver = getDriver(jdbcDriverClass);
connection = dbDriver.connect(jdbcConnectionUrl, new Properties());
+
+ if (logger.isTraceEnabled()) {
--- End diff --
How come this doesnt have the instance check?
---