You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by manishgupta88 <gi...@git.apache.org> on 2018/07/17 09:13:57 UTC
[GitHub] carbondata pull request #2515: [CARBONDATA-2714][Merge Index] Fixed block da...
GitHub user manishgupta88 opened a pull request:
https://github.com/apache/carbondata/pull/2515
[CARBONDATA-2714][Merge Index] Fixed block dataMap cache refresh issue after creation of merge index file
Things handled as part of this PR
1. Fixed block dataMap cache refresh issue after creation of merge index file
**Problem:**
Block DataMap cache not getting refreshed after creation of merge index file due to which queries still look for index file and fail.
**Analysis:**
Merge index file creation involves modification of segment file. If a query is executed without merge Index file creation then cache will be loaded. Once merge Index file is created the index file entries will be removed from segment file and merge index file entry will be added. In this process the cache is not getting refreshed and the tableIdentifiers created still have the mergeIndexFIleName as null.
**Fix:**
After updating table status file clear the dataMap cache for all segmentId's on which dataMap is being created
- [ ] Any interfaces changed?
No
- [ ] Any backward compatibility impacted?
No
- [ ] Document update required?
No
- [ ] Testing done
Added test case
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/manishgupta88/carbondata merge_index_clear_cache
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2515.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2515
----
commit d4d04ee4b6627384a02c922cbe2ead6a8b4f3ee6
Author: manishgupta88 <to...@...>
Date: 2018-07-17T08:54:54Z
Fixed block dataMap cache refresh issue after creation of merge index file
----
---
[GitHub] carbondata issue #2515: [CARBONDATA-2714][Merge Index] Fixed block dataMap c...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2515
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/5887/
---
[GitHub] carbondata issue #2515: [CARBONDATA-2714][Merge Index] Fixed block dataMap c...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2515
LGTM
---
[GitHub] carbondata pull request #2515: [CARBONDATA-2714][Merge Index] Fixed block da...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2515
---
[GitHub] carbondata issue #2515: [CARBONDATA-2714][Merge Index] Fixed block dataMap c...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2515
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/7249/
---
[GitHub] carbondata issue #2515: [CARBONDATA-2714][Merge Index] Fixed block dataMap c...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2515
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/6025/
---
[GitHub] carbondata issue #2515: [CARBONDATA-2714][Merge Index] Fixed block dataMap c...
Posted by brijoobopanna <gi...@git.apache.org>.
Github user brijoobopanna commented on the issue:
https://github.com/apache/carbondata/pull/2515
retest sdv please
---