You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/07/22 00:48:19 UTC
[kudu-CR] KUDU-2671 range-specific hash schema support in Python client
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18771
Change subject: KUDU-2671 range-specific hash schema support in Python client
......................................................................
KUDU-2671 range-specific hash schema support in Python client
With this patch, it's now possible to operate on ranges having custom
hash schemas in Kudu Python client applications. In essence, the newly
added API directly maps into the Kudu C++ client API. This patch also
contains tests to cover the newly introduced functionality.
Change-Id: I61426fadc45d70805cf99461d559f0152a79f4a0
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
3 files changed, 260 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/18771/1
--
To view, visit http://gerrit.cloudera.org:8080/18771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I61426fadc45d70805cf99461d559f0152a79f4a0
Gerrit-Change-Number: 18771
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] KUDU-2671 range-specific hash schema support in Python client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18771 )
Change subject: KUDU-2671 range-specific hash schema support in Python client
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18771/1/python/kudu/client.pyx
File python/kudu/client.pyx:
http://gerrit.cloudera.org:8080/#/c/18771/1/python/kudu/client.pyx@3314
PS1, Line 3314: p
> nit: Why not use the same variable name as in 1381 to keep it consistent?
Done
--
To view, visit http://gerrit.cloudera.org:8080/18771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61426fadc45d70805cf99461d559f0152a79f4a0
Gerrit-Change-Number: 18771
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 18:22:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2671 range-specific hash schema support in Python client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18771 )
Change subject: KUDU-2671 range-specific hash schema support in Python client
......................................................................
KUDU-2671 range-specific hash schema support in Python client
With this patch, it's now possible to operate on ranges having custom
hash schemas in Kudu Python client applications. In essence, the newly
added API directly maps into the Kudu C++ client API. This patch also
contains tests to cover the newly introduced functionality.
Change-Id: I61426fadc45d70805cf99461d559f0152a79f4a0
Reviewed-on: http://gerrit.cloudera.org:8080/18771
Reviewed-by: Attila Bukor <ab...@apache.org>
Tested-by: Kudu Jenkins
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
3 files changed, 260 insertions(+), 2 deletions(-)
Approvals:
Attila Bukor: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I61426fadc45d70805cf99461d559f0152a79f4a0
Gerrit-Change-Number: 18771
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 range-specific hash schema support in Python client
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18771 )
Change subject: KUDU-2671 range-specific hash schema support in Python client
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61426fadc45d70805cf99461d559f0152a79f4a0
Gerrit-Change-Number: 18771
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 22:09:29 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 range-specific hash schema support in Python client
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18771 )
Change subject: KUDU-2671 range-specific hash schema support in Python client
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18771/1/python/kudu/client.pyx
File python/kudu/client.pyx:
http://gerrit.cloudera.org:8080/#/c/18771/1/python/kudu/client.pyx@3314
PS1, Line 3314: p
nit: Why not use the same variable name as in 1381 to keep it consistent?
--
To view, visit http://gerrit.cloudera.org:8080/18771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61426fadc45d70805cf99461d559f0152a79f4a0
Gerrit-Change-Number: 18771
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 16:35:27 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2671 range-specific hash schema support in Python client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Attila Bukor, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18771
to look at the new patch set (#2).
Change subject: KUDU-2671 range-specific hash schema support in Python client
......................................................................
KUDU-2671 range-specific hash schema support in Python client
With this patch, it's now possible to operate on ranges having custom
hash schemas in Kudu Python client applications. In essence, the newly
added API directly maps into the Kudu C++ client API. This patch also
contains tests to cover the newly introduced functionality.
Change-Id: I61426fadc45d70805cf99461d559f0152a79f4a0
---
M python/kudu/client.pyx
M python/kudu/libkudu_client.pxd
M python/kudu/tests/test_client.py
3 files changed, 260 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/18771/2
--
To view, visit http://gerrit.cloudera.org:8080/18771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I61426fadc45d70805cf99461d559f0152a79f4a0
Gerrit-Change-Number: 18771
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 range-specific hash schema support in Python client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18771 )
Change subject: KUDU-2671 range-specific hash schema support in Python client
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18771
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I61426fadc45d70805cf99461d559f0152a79f4a0
Gerrit-Change-Number: 18771
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 20:24:58 +0000
Gerrit-HasComments: No