You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/05/17 00:16:43 UTC
[I] REmove workaround for 1COUNT(*)` in subquery decorrelation code [datafusion]
alamb opened a new issue, #10553:
URL: https://github.com/apache/datafusion/issues/10553
### Is your feature request related to a problem or challenge?
While working on https://github.com/apache/datafusion/pull/10500 I found reference to "the count" bug in the code but it wasn't clear it was tracked by any ticket
@comphead figured out https://github.com/apache/datafusion/pull/10500#discussion_r1603532658 that if the relevant workaround is disabled, then the following query is incorrect:
```
Running "subquery.slt"
External error: query result mismatch:
[SQL] SELECT t1_id, (SELECT count(*) FROM t2 WHERE t2.t2_int = t1.t1_int) from t1
[Diff] (-expected|+actual)
11 1
- 22 0
+ 22 NULL
33 3
- 44 0
+ 44 NULL
at test_files/subquery.slt:763
```
### Describe the solution you'd like
Remove the workaround / handle the issue correctly
I am not quite sure what this means (maybe @mingmwang can provide more details if he has time)
### Describe alternatives you've considered
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Remove workaround for `COUNT(*)` in subquery decorrelation code [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #10553: Remove workaround for `COUNT(*)` in subquery decorrelation code
URL: https://github.com/apache/datafusion/issues/10553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Remove workaround for `COUNT(*)` in subquery decorrelation code [datafusion]
Posted by "suibianwanwank (via GitHub)" <gi...@apache.org>.
suibianwanwank commented on issue #10553:
URL: https://github.com/apache/datafusion/issues/10553#issuecomment-2701486148
Hi, @alamb. I described the "count-bug" bug in https://github.com/apache/datafusion/issues/15032. Maybe I can try to optimize this comment~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Remove workaround for `COUNT(*)` in subquery decorrelation code [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #10553:
URL: https://github.com/apache/datafusion/issues/10553#issuecomment-2707564784
For anyone following along, from @suibianwanwank's PR I wanted to post this link here:
> The "count bug" was described in [Optimization of Nested SQL Queries Revisited](https://dl.acm.org/doi/pdf/10.1145/38714.38723)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Remove workaround for `COUNT(*)` in subquery decorrelation code [datafusion]
Posted by "suibianwanwank (via GitHub)" <gi...@apache.org>.
suibianwanwank commented on issue #10553:
URL: https://github.com/apache/datafusion/issues/10553#issuecomment-2706666310
@alamb I have submitted a PR. When you have time, greatly appreciate your review. As I am new to DataFusion, any feedback for improvement would be very helpful. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org