You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ti...@apache.org on 2022/03/27 10:05:06 UTC
[maven-surefire] branch SUREFIRE-2040 updated: checkstyle and assertions
This is an automated email from the ASF dual-hosted git repository.
tibordigana pushed a commit to branch SUREFIRE-2040
in repository https://gitbox.apache.org/repos/asf/maven-surefire.git
The following commit(s) were added to refs/heads/SUREFIRE-2040 by this push:
new 6356cce checkstyle and assertions
6356cce is described below
commit 6356ccef44f4f4d143043cd669bd971d7d04d4df
Author: tibordigana <ti...@apache.org>
AuthorDate: Sun Mar 27 12:04:54 2022 +0200
checkstyle and assertions
---
.../surefire/junitplatform/JUnitPlatformProvider.java | 1 -
.../junitplatform/JUnitPlatformProviderTest.java | 16 ++++++++++++----
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java b/surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java
index a376298..ad2ec94 100644
--- a/surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java
+++ b/surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java
@@ -56,7 +56,6 @@ import org.apache.maven.surefire.api.provider.ProviderParameters;
import org.apache.maven.surefire.api.report.ReporterException;
import org.apache.maven.surefire.api.report.ReporterFactory;
import org.apache.maven.surefire.api.suite.RunResult;
-import org.apache.maven.surefire.api.testset.TestListResolver;
import org.apache.maven.surefire.api.testset.TestSetFailedException;
import org.apache.maven.surefire.api.util.ScanResult;
import org.apache.maven.surefire.api.util.SurefireReflectionException;
diff --git a/surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java b/surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java
index 179db2a..f734bab 100644
--- a/surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java
+++ b/surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProviderTest.java
@@ -905,12 +905,18 @@ public class JUnitPlatformProviderTest
JUnitPlatformProvider provider = new JUnitPlatformProvider( providerParameters );
- assertEquals( provider.getFilters().length, 1 );
+ assertThat( provider.getFilters() )
+ .hasSize( 1 );
assertThat( provider.getFilters()[0] )
.isInstanceOf( TestMethodFilter.class );
- assertThat( (TestListResolver) getInternalState( provider.getFilters()[0], "testListResolver" ) )
+ Object expectedTestListResolver = getInternalState( provider.getFilters()[0], "testListResolver" );
+
+ assertThat( expectedTestListResolver )
+ .isInstanceOf( TestListResolver.class );
+
+ assertThat( expectedTestListResolver )
.isSameAs( testListResolver );
}
@@ -926,7 +932,8 @@ public class JUnitPlatformProviderTest
JUnitPlatformProvider provider = new JUnitPlatformProvider( providerParameters );
- assertEquals( provider.getFilters().length, 0 );
+ assertThat( provider.getFilters() )
+ .isEmpty();
}
@Test
@@ -941,7 +948,8 @@ public class JUnitPlatformProviderTest
JUnitPlatformProvider provider = new JUnitPlatformProvider( providerParameters );
- assertEquals( provider.getFilters().length, 0 );
+ assertThat( provider.getFilters() )
+ .isEmpty();
}
@Test