[GitHub] [maven-site] psiroky commented on a diff in pull request #371: Plugin testing: fix deprecated verifier calls

[GitBox <gi...@apache.org>]

psiroky commented on code in PR #371:
URL: https://github.com/apache/maven-site/pull/371#discussion_r1081338234


##########
content/apt/plugin-developers/plugin-testing.apt:
##########
@@ -144,16 +144,16 @@ public class TrivialMavenVerifierTest extends TestCase
         verifier.deleteArtifact( "org.apache.maven.its.itsample", "checkstyle-assembly", "1.0", "jar" );
 
         /*
-         * The Command Line Options (CLI) are passed to the
-         * verifier as a list. This is handy for things like
+         * Command line options / arguments are passed to the verifier
+         * as strings, similarly as we would when calling Maven
+         * directly from command line. This is handy for things like
          * redefining the local repository if needed. In
          * this case, we use the -N flag so that Maven won't
          * recurse. We are only installing the parent pom to
          * the local repo here.
          */
-        List cliOptions = new ArrayList();
-        cliOptions.add( "-N" );
-        verifier.executeGoal( "install" );

Review Comment:
   Unless I am missing something, the original code did not make much sense, because the `cliOptions` list was never used by verifier. With the newer verifier version, there is no need for a list since the method uses variable length arg).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org