You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Yonik Seeley (JIRA)" <ji...@apache.org> on 2008/04/13 18:35:06 UTC

[jira] Commented: (SOLR-486) Support binary formats for QueryresponseWriter

    [ https://issues.apache.org/jira/browse/SOLR-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588402#action_12588402 ] 

Yonik Seeley commented on SOLR-486:
-----------------------------------

I'm hacking on this now... I like how you separated the dependency on lucene-specific stuff via the resolver.  The problem is that we lose streaming ability for doc lists... if someone requests 1000 documents or whatever, everything is blown up in memory which could cause an OOM.  I'm adding the ability for the resolver to call back to the codec... not as nicely separated, but better results.

> Support binary formats for QueryresponseWriter
> ----------------------------------------------
>
>                 Key: SOLR-486
>                 URL: https://issues.apache.org/jira/browse/SOLR-486
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java, search
>            Reporter: Noble Paul
>            Assignee: Yonik Seeley
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-486.patch, SOLR-486.patch, SOLR-486.patch, SOLR-486.patch, SOLR-486.patch, SOLR-486.patch
>
>
> QueryResponse writer only allows text data to be written.
> So it is not possible to implement a binary protocol . Create another interface which has a method 
> write(OutputStream os, SolrQueryRequest request, SolrQueryResponse response)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Commented: (SOLR-486) Support binary formats for QueryresponseWriter

Posted by Noble Paul നോബിള്‍ नोब्ळ् <no...@gmail.com>.
that is great.
my intend was to make NamedListCodec very small and have as few
dependencies on other things
May be we can extend NamedList (which you may be doing already now.)
I never quite thought about streaming  :(
I may be able to take a look once you post your patch.

--Noble

On Sun, Apr 13, 2008 at 10:05 PM, Yonik Seeley (JIRA) <ji...@apache.org> wrote:
>
>
>     [ https://issues.apache.org/jira/browse/SOLR-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588402#action_12588402 ]
>
>  Yonik Seeley commented on SOLR-486:
>  -----------------------------------
>
>  I'm hacking on this now... I like how you separated the dependency on lucene-specific stuff via the resolver.  The problem is that we lose streaming ability for doc lists... if someone requests 1000 documents or whatever, everything is blown up in memory which could cause an OOM.  I'm adding the ability for the resolver to call back to the codec... not as nicely separated, but better results.
>
>  > Support binary formats for QueryresponseWriter
>  > ----------------------------------------------
>  >
>  >                 Key: SOLR-486
>  >                 URL: https://issues.apache.org/jira/browse/SOLR-486
>  >             Project: Solr
>  >          Issue Type: Improvement
>  >          Components: clients - java, search
>  >            Reporter: Noble Paul
>  >            Assignee: Yonik Seeley
>  >            Priority: Minor
>  >             Fix For: 1.3
>  >
>  >         Attachments: SOLR-486.patch, SOLR-486.patch, SOLR-486.patch, SOLR-486.patch, SOLR-486.patch, SOLR-486.patch
>  >
>  >
>  > QueryResponse writer only allows text data to be written.
>  > So it is not possible to implement a binary protocol . Create another interface which has a method
>  > write(OutputStream os, SolrQueryRequest request, SolrQueryResponse response)
>
>  --
>  This message is automatically generated by JIRA.
>  -
>  You can reply to this email to add a comment to the issue online.
>
>



-- 
--Noble Paul