You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Robert Levas <rl...@hortonworks.com> on 2016/01/16 00:42:48 UTC
Review Request 42369: Kerberos automation logic should use stack
advisor when determining configuration updates
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42369/
-----------------------------------------------------------
Review request for Ambari, Robert Nettleton, Sandor Magyari, and Srimanth Gunturi.
Bugs: AMBARI-14698
https://issues.apache.org/jira/browse/AMBARI-14698
Repository: ambari
Description
-------
Kerberos automation logic should use the stack advisor when determining configuration updates. This will ensure that property updates are valid given the cluster's configuration and whether the cluster was created using the API, UI, or BluePrints.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java 337ad06
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java b6686b4
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 6f0fa27
ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java 4c241d1
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 359e651
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 8ab04ff
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 84248dc
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java fba3eea
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 1e89272
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py ca7d2dd
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessorTest.java d5531a6
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 8861549
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java d1886b9
Diff: https://reviews.apache.org/r/42369/diff/
Testing
-------
Manualled tested:
- creating a cluster via the UI then enabling Kerberos and disabling Kerberos
- creating a cluster via Blueprints then enabling Kerberos and disabling Kerberos
- creating a Kerberized cluster via Blueprints then disabling Kerberos
# Local test results: PASSED
# Jenkins test results: PENDING
Thanks,
Robert Levas
Re: Review Request 42369: Kerberos automation logic should use stack
advisor when determining configuration updates
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42369/#review115037
-----------------------------------------------------------
Ship it!
Ship it after Sandor's comments addresed
- Sebastian Toader
On Jan. 16, 2016, 12:25 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42369/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2016, 12:25 p.m.)
>
>
> Review request for Ambari, Robert Nettleton, Sandor Magyari, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-14698
> https://issues.apache.org/jira/browse/AMBARI-14698
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Kerberos automation logic should use the stack advisor when determining configuration updates. This will ensure that property updates are valid given the cluster's configuration and whether the cluster was created using the API, UI, or BluePrints.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java 337ad06
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java b6686b4
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 6f0fa27
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java 4c241d1
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 359e651
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 8ab04ff
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 84248dc
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java fba3eea
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 1e89272
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py ca7d2dd
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessorTest.java d5531a6
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 8861549
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java d1886b9
>
> Diff: https://reviews.apache.org/r/42369/diff/
>
>
> Testing
> -------
>
> Manualled tested:
> - creating a cluster via the UI then enabling Kerberos and disabling Kerberos
> - creating a cluster via Blueprints then enabling Kerberos and disabling Kerberos
> - creating a Kerberized cluster via Blueprints then disabling Kerberos
>
> # Local test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:08:31.852s
> [INFO] Finished at: Fri Jan 15 19:39:40 EST 2016
> [INFO] Final Memory: 56M/1632M
> [INFO] ------------------------------------------------------------------------
>
> # Jenkins test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:54 h
> [INFO] Finished at: 2016-01-16T05:54:09+00:00
> [INFO] Final Memory: 135M/643M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 42369: Kerberos automation logic should use stack
advisor when determining configuration updates
Posted by Robert Levas <rl...@hortonworks.com>.
> On Jan. 18, 2016, 11:21 a.m., Sandor Magyari wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java, line 421
> > <https://reviews.apache.org/r/42369/diff/1/?file=1199000#file1199000line421>
> >
> > As I understand there's no need to call stackAdvisor from KerberosHelper in case of Blueprints. Can't we pass in some boolean to not apply stackAdvisor in case of Blueprints? Checking hosts might be tricky since some host may already present in cluster, other may not.
Good idea... implementing this.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42369/#review115015
-----------------------------------------------------------
On Jan. 16, 2016, 6:25 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42369/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2016, 6:25 a.m.)
>
>
> Review request for Ambari, Robert Nettleton, Sandor Magyari, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-14698
> https://issues.apache.org/jira/browse/AMBARI-14698
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Kerberos automation logic should use the stack advisor when determining configuration updates. This will ensure that property updates are valid given the cluster's configuration and whether the cluster was created using the API, UI, or BluePrints.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java 337ad06
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java b6686b4
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 6f0fa27
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java 4c241d1
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 359e651
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 8ab04ff
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 84248dc
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java fba3eea
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 1e89272
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py ca7d2dd
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessorTest.java d5531a6
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 8861549
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java d1886b9
>
> Diff: https://reviews.apache.org/r/42369/diff/
>
>
> Testing
> -------
>
> Manualled tested:
> - creating a cluster via the UI then enabling Kerberos and disabling Kerberos
> - creating a cluster via Blueprints then enabling Kerberos and disabling Kerberos
> - creating a Kerberized cluster via Blueprints then disabling Kerberos
>
> # Local test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:08:31.852s
> [INFO] Finished at: Fri Jan 15 19:39:40 EST 2016
> [INFO] Final Memory: 56M/1632M
> [INFO] ------------------------------------------------------------------------
>
> # Jenkins test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:54 h
> [INFO] Finished at: 2016-01-16T05:54:09+00:00
> [INFO] Final Memory: 135M/643M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 42369: Kerberos automation logic should use stack
advisor when determining configuration updates
Posted by Robert Levas <rl...@hortonworks.com>.
> On Jan. 18, 2016, 11:21 a.m., Sandor Magyari wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java, line 120
> > <https://reviews.apache.org/r/42369/diff/1/?file=1198998#file1198998line120>
> >
> > BlueprintConfigurationsProcessor.setMissingProperties sets this property in cluster-env as well. May be we can move this out to ClusterConfigurationRequest.configureKerberos() ?
>
> Robert Levas wrote:
> While testing, this value was not set when needed while accessing the Stack Advisor. It is necessary for cluster-env/security-enabled to be set to "true" if we are to enable Kerberos so that the Stack Advisor behaves as we Kerberos was enabled - though it is not yet enabled according to the exsting configs.
>
> Oliver Szabo wrote:
> now, stack advisor called after configureKerberos(), maybe that's better place for setting any values which related to kerberos. if after then the stack advisor unset security-enabled property, then the problem with stack advisor logic (python part)
Currently security_enabled is being set in org.apache.ambari.server.controller.internal.BlueprintConfigurationProcessor#setMissingConfigurations. The stack advisor is not changing the value, its just the order of operations does not lend itself to setting the value when needed.
On this note, there was a ready we waited to set security_enabled... but that reason may have gone away now.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42369/#review115015
-----------------------------------------------------------
On Jan. 16, 2016, 6:25 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42369/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2016, 6:25 a.m.)
>
>
> Review request for Ambari, Robert Nettleton, Sandor Magyari, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-14698
> https://issues.apache.org/jira/browse/AMBARI-14698
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Kerberos automation logic should use the stack advisor when determining configuration updates. This will ensure that property updates are valid given the cluster's configuration and whether the cluster was created using the API, UI, or BluePrints.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java 337ad06
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java b6686b4
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 6f0fa27
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java 4c241d1
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 359e651
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 8ab04ff
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 84248dc
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java fba3eea
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 1e89272
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py ca7d2dd
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessorTest.java d5531a6
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 8861549
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java d1886b9
>
> Diff: https://reviews.apache.org/r/42369/diff/
>
>
> Testing
> -------
>
> Manualled tested:
> - creating a cluster via the UI then enabling Kerberos and disabling Kerberos
> - creating a cluster via Blueprints then enabling Kerberos and disabling Kerberos
> - creating a Kerberized cluster via Blueprints then disabling Kerberos
>
> # Local test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:08:31.852s
> [INFO] Finished at: Fri Jan 15 19:39:40 EST 2016
> [INFO] Final Memory: 56M/1632M
> [INFO] ------------------------------------------------------------------------
>
> # Jenkins test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:54 h
> [INFO] Finished at: 2016-01-16T05:54:09+00:00
> [INFO] Final Memory: 135M/643M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 42369: Kerberos automation logic should use stack
advisor when determining configuration updates
Posted by Oliver Szabo <os...@hortonworks.com>.
> On Jan. 18, 2016, 4:21 p.m., Sandor Magyari wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java, line 421
> > <https://reviews.apache.org/r/42369/diff/1/?file=1199000#file1199000line421>
> >
> > As I understand there's no need to call stackAdvisor from KerberosHelper in case of Blueprints. Can't we pass in some boolean to not apply stackAdvisor in case of Blueprints? Checking hosts might be tricky since some host may already present in cluster, other may not.
>
> Robert Levas wrote:
> Good idea... implementing this.
stack advisor only called if the recommendation strategy is not NEVER_APPLY (default), so its possible with blueprints, stack advisor wont be used. just be aware of it
> On Jan. 18, 2016, 4:21 p.m., Sandor Magyari wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java, line 120
> > <https://reviews.apache.org/r/42369/diff/1/?file=1198998#file1198998line120>
> >
> > BlueprintConfigurationsProcessor.setMissingProperties sets this property in cluster-env as well. May be we can move this out to ClusterConfigurationRequest.configureKerberos() ?
>
> Robert Levas wrote:
> While testing, this value was not set when needed while accessing the Stack Advisor. It is necessary for cluster-env/security-enabled to be set to "true" if we are to enable Kerberos so that the Stack Advisor behaves as we Kerberos was enabled - though it is not yet enabled according to the exsting configs.
now, stack advisor called after configureKerberos(), maybe that's better place for setting any values which related to kerberos. if after then the stack advisor unset security-enabled property, then the problem with stack advisor logic (python part)
- Oliver
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42369/#review115015
-----------------------------------------------------------
On Jan. 16, 2016, 11:25 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42369/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2016, 11:25 a.m.)
>
>
> Review request for Ambari, Robert Nettleton, Sandor Magyari, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-14698
> https://issues.apache.org/jira/browse/AMBARI-14698
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Kerberos automation logic should use the stack advisor when determining configuration updates. This will ensure that property updates are valid given the cluster's configuration and whether the cluster was created using the API, UI, or BluePrints.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java 337ad06
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java b6686b4
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 6f0fa27
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java 4c241d1
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 359e651
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 8ab04ff
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 84248dc
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java fba3eea
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 1e89272
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py ca7d2dd
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessorTest.java d5531a6
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 8861549
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java d1886b9
>
> Diff: https://reviews.apache.org/r/42369/diff/
>
>
> Testing
> -------
>
> Manualled tested:
> - creating a cluster via the UI then enabling Kerberos and disabling Kerberos
> - creating a cluster via Blueprints then enabling Kerberos and disabling Kerberos
> - creating a Kerberized cluster via Blueprints then disabling Kerberos
>
> # Local test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:08:31.852s
> [INFO] Finished at: Fri Jan 15 19:39:40 EST 2016
> [INFO] Final Memory: 56M/1632M
> [INFO] ------------------------------------------------------------------------
>
> # Jenkins test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:54 h
> [INFO] Finished at: 2016-01-16T05:54:09+00:00
> [INFO] Final Memory: 135M/643M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 42369: Kerberos automation logic should use stack
advisor when determining configuration updates
Posted by Robert Levas <rl...@hortonworks.com>.
> On Jan. 18, 2016, 11:21 a.m., Sandor Magyari wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java, line 120
> > <https://reviews.apache.org/r/42369/diff/1/?file=1198998#file1198998line120>
> >
> > BlueprintConfigurationsProcessor.setMissingProperties sets this property in cluster-env as well. May be we can move this out to ClusterConfigurationRequest.configureKerberos() ?
While testing, this value was not set when needed while accessing the Stack Advisor. It is necessary for cluster-env/security-enabled to be set to "true" if we are to enable Kerberos so that the Stack Advisor behaves as we Kerberos was enabled - though it is not yet enabled according to the exsting configs.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42369/#review115015
-----------------------------------------------------------
On Jan. 16, 2016, 6:25 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42369/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2016, 6:25 a.m.)
>
>
> Review request for Ambari, Robert Nettleton, Sandor Magyari, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-14698
> https://issues.apache.org/jira/browse/AMBARI-14698
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Kerberos automation logic should use the stack advisor when determining configuration updates. This will ensure that property updates are valid given the cluster's configuration and whether the cluster was created using the API, UI, or BluePrints.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java 337ad06
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java b6686b4
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 6f0fa27
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java 4c241d1
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 359e651
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 8ab04ff
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 84248dc
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java fba3eea
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 1e89272
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py ca7d2dd
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessorTest.java d5531a6
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 8861549
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java d1886b9
>
> Diff: https://reviews.apache.org/r/42369/diff/
>
>
> Testing
> -------
>
> Manualled tested:
> - creating a cluster via the UI then enabling Kerberos and disabling Kerberos
> - creating a cluster via Blueprints then enabling Kerberos and disabling Kerberos
> - creating a Kerberized cluster via Blueprints then disabling Kerberos
>
> # Local test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:08:31.852s
> [INFO] Finished at: Fri Jan 15 19:39:40 EST 2016
> [INFO] Final Memory: 56M/1632M
> [INFO] ------------------------------------------------------------------------
>
> # Jenkins test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:54 h
> [INFO] Finished at: 2016-01-16T05:54:09+00:00
> [INFO] Final Memory: 135M/643M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 42369: Kerberos automation logic should use stack
advisor when determining configuration updates
Posted by Sandor Magyari <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42369/#review115015
-----------------------------------------------------------
Ship it!
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java (line 120)
<https://reviews.apache.org/r/42369/#comment175867>
BlueprintConfigurationsProcessor.setMissingProperties sets this property in cluster-env as well. May be we can move this out to ClusterConfigurationRequest.configureKerberos() ?
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java (line 418)
<https://reviews.apache.org/r/42369/#comment175868>
As I understand there's no need to call stackAdvisor from KerberosHelper in case of Blueprints. Can't we pass in some boolean to not apply stackAdvisor in case of Blueprints? Checking hosts might be tricky since some host may already present in cluster, other may not.
- Sandor Magyari
On Jan. 16, 2016, 11:25 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42369/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2016, 11:25 a.m.)
>
>
> Review request for Ambari, Robert Nettleton, Sandor Magyari, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-14698
> https://issues.apache.org/jira/browse/AMBARI-14698
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Kerberos automation logic should use the stack advisor when determining configuration updates. This will ensure that property updates are valid given the cluster's configuration and whether the cluster was created using the API, UI, or BluePrints.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java 337ad06
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java b6686b4
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 6f0fa27
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java 4c241d1
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 359e651
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 8ab04ff
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 84248dc
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java fba3eea
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 1e89272
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py ca7d2dd
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessorTest.java d5531a6
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 8861549
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java d1886b9
>
> Diff: https://reviews.apache.org/r/42369/diff/
>
>
> Testing
> -------
>
> Manualled tested:
> - creating a cluster via the UI then enabling Kerberos and disabling Kerberos
> - creating a cluster via Blueprints then enabling Kerberos and disabling Kerberos
> - creating a Kerberized cluster via Blueprints then disabling Kerberos
>
> # Local test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:08:31.852s
> [INFO] Finished at: Fri Jan 15 19:39:40 EST 2016
> [INFO] Final Memory: 56M/1632M
> [INFO] ------------------------------------------------------------------------
>
> # Jenkins test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:54 h
> [INFO] Finished at: 2016-01-16T05:54:09+00:00
> [INFO] Final Memory: 135M/643M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 42369: Kerberos automation logic should use stack
advisor when determining configuration updates
Posted by Ajit Kumar <aj...@hortonworks.com>.
> On Jan. 18, 2016, 4:48 p.m., Ajit Kumar wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java, line 433
> > <https://reviews.apache.org/r/42369/diff/1/?file=1199000#file1199000line433>
> >
> > new ArrayList<>(); should be ok.
>
> Robert Levas wrote:
> I am not sure if this is valid for current Ambari coding standards.
Currently ambari is using JDK 7 which supports diamond operators.
> On Jan. 18, 2016, 4:48 p.m., Ajit Kumar wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java, line 478
> > <https://reviews.apache.org/r/42369/diff/1/?file=1199000#file1199000line478>
> >
> > It will be better to add empty collection than null.
>
> Robert Levas wrote:
> If I did that, then in this case the ArrayList would be created twice, rather than once. See the next few lines where the "properties" list is further processed.
If you want to avoid creation of collection twice, you can just use Collections.emptyMap() instead of null;
Now you don't need following line of code:
if (requestConfigurationProperties == null) {
requestConfigurationProperties = new HashMap<String, String>();
}
- Ajit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42369/#review115017
-----------------------------------------------------------
On Jan. 16, 2016, 11:25 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42369/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2016, 11:25 a.m.)
>
>
> Review request for Ambari, Robert Nettleton, Sandor Magyari, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-14698
> https://issues.apache.org/jira/browse/AMBARI-14698
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Kerberos automation logic should use the stack advisor when determining configuration updates. This will ensure that property updates are valid given the cluster's configuration and whether the cluster was created using the API, UI, or BluePrints.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java 337ad06
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java b6686b4
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 6f0fa27
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java 4c241d1
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 359e651
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 8ab04ff
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 84248dc
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java fba3eea
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 1e89272
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py ca7d2dd
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessorTest.java d5531a6
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 8861549
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java d1886b9
>
> Diff: https://reviews.apache.org/r/42369/diff/
>
>
> Testing
> -------
>
> Manualled tested:
> - creating a cluster via the UI then enabling Kerberos and disabling Kerberos
> - creating a cluster via Blueprints then enabling Kerberos and disabling Kerberos
> - creating a Kerberized cluster via Blueprints then disabling Kerberos
>
> # Local test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:08:31.852s
> [INFO] Finished at: Fri Jan 15 19:39:40 EST 2016
> [INFO] Final Memory: 56M/1632M
> [INFO] ------------------------------------------------------------------------
>
> # Jenkins test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:54 h
> [INFO] Finished at: 2016-01-16T05:54:09+00:00
> [INFO] Final Memory: 135M/643M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 42369: Kerberos automation logic should use stack
advisor when determining configuration updates
Posted by Robert Levas <rl...@hortonworks.com>.
> On Jan. 18, 2016, 11:48 a.m., Ajit Kumar wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java, line 478
> > <https://reviews.apache.org/r/42369/diff/1/?file=1199000#file1199000line478>
> >
> > It will be better to add empty collection than null.
>
> Robert Levas wrote:
> If I did that, then in this case the ArrayList would be created twice, rather than once. See the next few lines where the "properties" list is further processed.
>
> Ajit Kumar wrote:
> If you want to avoid creation of collection twice, you can just use Collections.emptyMap() instead of null;
>
> Now you don't need following line of code:
> if (requestConfigurationProperties == null) {
> requestConfigurationProperties = new HashMap<String, String>();
> }
I will still need to check for null, since I don't know what the passed in values have. But I will add your suggestion since I am making some other changes.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42369/#review115017
-----------------------------------------------------------
On Jan. 16, 2016, 6:25 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42369/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2016, 6:25 a.m.)
>
>
> Review request for Ambari, Robert Nettleton, Sandor Magyari, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-14698
> https://issues.apache.org/jira/browse/AMBARI-14698
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Kerberos automation logic should use the stack advisor when determining configuration updates. This will ensure that property updates are valid given the cluster's configuration and whether the cluster was created using the API, UI, or BluePrints.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java 337ad06
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java b6686b4
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 6f0fa27
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java 4c241d1
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 359e651
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 8ab04ff
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 84248dc
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java fba3eea
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 1e89272
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py ca7d2dd
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessorTest.java d5531a6
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 8861549
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java d1886b9
>
> Diff: https://reviews.apache.org/r/42369/diff/
>
>
> Testing
> -------
>
> Manualled tested:
> - creating a cluster via the UI then enabling Kerberos and disabling Kerberos
> - creating a cluster via Blueprints then enabling Kerberos and disabling Kerberos
> - creating a Kerberized cluster via Blueprints then disabling Kerberos
>
> # Local test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:08:31.852s
> [INFO] Finished at: Fri Jan 15 19:39:40 EST 2016
> [INFO] Final Memory: 56M/1632M
> [INFO] ------------------------------------------------------------------------
>
> # Jenkins test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:54 h
> [INFO] Finished at: 2016-01-16T05:54:09+00:00
> [INFO] Final Memory: 135M/643M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 42369: Kerberos automation logic should use stack
advisor when determining configuration updates
Posted by Robert Levas <rl...@hortonworks.com>.
> On Jan. 18, 2016, 11:48 a.m., Ajit Kumar wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java, line 433
> > <https://reviews.apache.org/r/42369/diff/1/?file=1199000#file1199000line433>
> >
> > new ArrayList<>(); should be ok.
I am not sure if this is valid for current Ambari coding standards.
> On Jan. 18, 2016, 11:48 a.m., Ajit Kumar wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java, line 478
> > <https://reviews.apache.org/r/42369/diff/1/?file=1199000#file1199000line478>
> >
> > It will be better to add empty collection than null.
If I did that, then in this case the ArrayList would be created twice, rather than once. See the next few lines where the "properties" list is further processed.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42369/#review115017
-----------------------------------------------------------
On Jan. 16, 2016, 6:25 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42369/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2016, 6:25 a.m.)
>
>
> Review request for Ambari, Robert Nettleton, Sandor Magyari, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-14698
> https://issues.apache.org/jira/browse/AMBARI-14698
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Kerberos automation logic should use the stack advisor when determining configuration updates. This will ensure that property updates are valid given the cluster's configuration and whether the cluster was created using the API, UI, or BluePrints.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java 337ad06
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java b6686b4
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 6f0fa27
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java 4c241d1
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 359e651
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 8ab04ff
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 84248dc
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java fba3eea
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 1e89272
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py ca7d2dd
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessorTest.java d5531a6
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 8861549
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java d1886b9
>
> Diff: https://reviews.apache.org/r/42369/diff/
>
>
> Testing
> -------
>
> Manualled tested:
> - creating a cluster via the UI then enabling Kerberos and disabling Kerberos
> - creating a cluster via Blueprints then enabling Kerberos and disabling Kerberos
> - creating a Kerberized cluster via Blueprints then disabling Kerberos
>
> # Local test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:08:31.852s
> [INFO] Finished at: Fri Jan 15 19:39:40 EST 2016
> [INFO] Final Memory: 56M/1632M
> [INFO] ------------------------------------------------------------------------
>
> # Jenkins test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:54 h
> [INFO] Finished at: 2016-01-16T05:54:09+00:00
> [INFO] Final Memory: 135M/643M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 42369: Kerberos automation logic should use stack
advisor when determining configuration updates
Posted by Ajit Kumar <aj...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42369/#review115017
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java (line 430)
<https://reviews.apache.org/r/42369/#comment175869>
new ArrayList<>(); should be ok.
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java (line 444)
<https://reviews.apache.org/r/42369/#comment175870>
same here
new HashMap<>();
no need to add type.
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java (line 447)
<https://reviews.apache.org/r/42369/#comment175871>
new HashMap<>()
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java (line 474)
<https://reviews.apache.org/r/42369/#comment175872>
new HashMap<>()
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java (line 475)
<https://reviews.apache.org/r/42369/#comment175874>
It will be better to add empty collection than null.
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java (line 207)
<https://reviews.apache.org/r/42369/#comment175873>
You can use CollectionUtils.isEmpty/CollectionUtils.isNotEmpty and you won't have to add explicit null check.
- Ajit Kumar
On Jan. 16, 2016, 11:25 a.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42369/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2016, 11:25 a.m.)
>
>
> Review request for Ambari, Robert Nettleton, Sandor Magyari, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-14698
> https://issues.apache.org/jira/browse/AMBARI-14698
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Kerberos automation logic should use the stack advisor when determining configuration updates. This will ensure that property updates are valid given the cluster's configuration and whether the cluster was created using the API, UI, or BluePrints.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java 337ad06
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java b6686b4
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 6f0fa27
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java 4c241d1
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 359e651
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 8ab04ff
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 84248dc
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java fba3eea
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 1e89272
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py ca7d2dd
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessorTest.java d5531a6
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 8861549
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java d1886b9
>
> Diff: https://reviews.apache.org/r/42369/diff/
>
>
> Testing
> -------
>
> Manualled tested:
> - creating a cluster via the UI then enabling Kerberos and disabling Kerberos
> - creating a cluster via Blueprints then enabling Kerberos and disabling Kerberos
> - creating a Kerberized cluster via Blueprints then disabling Kerberos
>
> # Local test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:08:31.852s
> [INFO] Finished at: Fri Jan 15 19:39:40 EST 2016
> [INFO] Final Memory: 56M/1632M
> [INFO] ------------------------------------------------------------------------
>
> # Jenkins test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:54 h
> [INFO] Finished at: 2016-01-16T05:54:09+00:00
> [INFO] Final Memory: 135M/643M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 42369: Kerberos automation logic should use stack
advisor when determining configuration updates
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42369/#review115080
-----------------------------------------------------------
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java (line 46)
<https://reviews.apache.org/r/42369/#comment175940>
Just a small thing. Is using wildcard for imports allowed for ambari? if does not, fix it
- Oliver Szabo
On Jan. 18, 2016, 11:08 p.m., Robert Levas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42369/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 11:08 p.m.)
>
>
> Review request for Ambari, Robert Nettleton, Sandor Magyari, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-14698
> https://issues.apache.org/jira/browse/AMBARI-14698
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Kerberos automation logic should use the stack advisor when determining configuration updates. This will ensure that property updates are valid given the cluster's configuration and whether the cluster was created using the API, UI, or BluePrints.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java b6686b4
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 6f0fa27
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java dcedd51
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java 4c241d1
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 359e651
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 8ab04ff
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 84248dc
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java fba3eea
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 1e89272
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py ca7d2dd
> ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessorTest.java d5531a6
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 8861549
> ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java d1886b9
>
> Diff: https://reviews.apache.org/r/42369/diff/
>
>
> Testing
> -------
>
> Manualled tested:
> - creating a cluster via the UI then enabling Kerberos and disabling Kerberos
> - creating a cluster via Blueprints then enabling Kerberos and disabling Kerberos
> - creating a Kerberized cluster via Blueprints then disabling Kerberos
>
> # Local test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 1:08:31.852s
> [INFO] Finished at: Fri Jan 15 19:39:40 EST 2016
> [INFO] Final Memory: 56M/1632M
> [INFO] ------------------------------------------------------------------------
>
> # Jenkins test results:
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 01:54 h
> [INFO] Finished at: 2016-01-16T05:54:09+00:00
> [INFO] Final Memory: 135M/643M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 42369: Kerberos automation logic should use stack
advisor when determining configuration updates
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42369/
-----------------------------------------------------------
(Updated Jan. 18, 2016, 7:59 p.m.)
Review request for Ambari, Robert Nettleton, Sandor Magyari, and Srimanth Gunturi.
Bugs: AMBARI-14698
https://issues.apache.org/jira/browse/AMBARI-14698
Repository: ambari
Description
-------
Kerberos automation logic should use the stack advisor when determining configuration updates. This will ensure that property updates are valid given the cluster's configuration and whether the cluster was created using the API, UI, or BluePrints.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java b6686b4
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 6f0fa27
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java dcedd51
ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java 4c241d1
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 359e651
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 8ab04ff
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 84248dc
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java fba3eea
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 1e89272
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py ca7d2dd
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessorTest.java d5531a6
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 8861549
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java d1886b9
Diff: https://reviews.apache.org/r/42369/diff/
Testing
-------
Manualled tested:
- creating a cluster via the UI then enabling Kerberos and disabling Kerberos
- creating a cluster via Blueprints then enabling Kerberos and disabling Kerberos
- creating a Kerberized cluster via Blueprints then disabling Kerberos
# Local test results:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:08:31.852s
[INFO] Finished at: Fri Jan 15 19:39:40 EST 2016
[INFO] Final Memory: 56M/1632M
[INFO] ------------------------------------------------------------------------
# Jenkins test results:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:54 h
[INFO] Finished at: 2016-01-16T05:54:09+00:00
[INFO] Final Memory: 135M/643M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 42369: Kerberos automation logic should use stack
advisor when determining configuration updates
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42369/
-----------------------------------------------------------
(Updated Jan. 18, 2016, 6:08 p.m.)
Review request for Ambari, Robert Nettleton, Sandor Magyari, and Srimanth Gunturi.
Bugs: AMBARI-14698
https://issues.apache.org/jira/browse/AMBARI-14698
Repository: ambari
Description
-------
Kerberos automation logic should use the stack advisor when determining configuration updates. This will ensure that property updates are valid given the cluster's configuration and whether the cluster was created using the API, UI, or BluePrints.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java b6686b4
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 6f0fa27
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java dcedd51
ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java 4c241d1
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 359e651
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 8ab04ff
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 84248dc
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java fba3eea
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 1e89272
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py ca7d2dd
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessorTest.java d5531a6
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 8861549
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java d1886b9
Diff: https://reviews.apache.org/r/42369/diff/
Testing
-------
Manualled tested:
- creating a cluster via the UI then enabling Kerberos and disabling Kerberos
- creating a cluster via Blueprints then enabling Kerberos and disabling Kerberos
- creating a Kerberized cluster via Blueprints then disabling Kerberos
# Local test results:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:08:31.852s
[INFO] Finished at: Fri Jan 15 19:39:40 EST 2016
[INFO] Final Memory: 56M/1632M
[INFO] ------------------------------------------------------------------------
# Jenkins test results:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:54 h
[INFO] Finished at: 2016-01-16T05:54:09+00:00
[INFO] Final Memory: 135M/643M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 42369: Kerberos automation logic should use stack
advisor when determining configuration updates
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42369/
-----------------------------------------------------------
(Updated Jan. 16, 2016, 6:25 a.m.)
Review request for Ambari, Robert Nettleton, Sandor Magyari, and Srimanth Gunturi.
Bugs: AMBARI-14698
https://issues.apache.org/jira/browse/AMBARI-14698
Repository: ambari
Description
-------
Kerberos automation logic should use the stack advisor when determining configuration updates. This will ensure that property updates are valid given the cluster's configuration and whether the cluster was created using the API, UI, or BluePrints.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java 337ad06
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java b6686b4
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 6f0fa27
ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java 4c241d1
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 359e651
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 8ab04ff
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 84248dc
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java fba3eea
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 1e89272
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py ca7d2dd
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessorTest.java d5531a6
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 8861549
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java d1886b9
Diff: https://reviews.apache.org/r/42369/diff/
Testing (updated)
-------
Manualled tested:
- creating a cluster via the UI then enabling Kerberos and disabling Kerberos
- creating a cluster via Blueprints then enabling Kerberos and disabling Kerberos
- creating a Kerberized cluster via Blueprints then disabling Kerberos
# Local test results:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:08:31.852s
[INFO] Finished at: Fri Jan 15 19:39:40 EST 2016
[INFO] Final Memory: 56M/1632M
[INFO] ------------------------------------------------------------------------
# Jenkins test results:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:54 h
[INFO] Finished at: 2016-01-16T05:54:09+00:00
[INFO] Final Memory: 135M/643M
[INFO] ------------------------------------------------------------------------
Thanks,
Robert Levas
Re: Review Request 42369: Kerberos automation logic should use stack
advisor when determining configuration updates
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42369/
-----------------------------------------------------------
(Updated Jan. 15, 2016, 8:37 p.m.)
Review request for Ambari, Robert Nettleton, Sandor Magyari, and Srimanth Gunturi.
Bugs: AMBARI-14698
https://issues.apache.org/jira/browse/AMBARI-14698
Repository: ambari
Description
-------
Kerberos automation logic should use the stack advisor when determining configuration updates. This will ensure that property updates are valid given the cluster's configuration and whether the cluster was created using the API, UI, or BluePrints.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java 337ad06
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelper.java b6686b4
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java 6f0fa27
ambari-server/src/main/java/org/apache/ambari/server/serveraction/ServerActionExecutor.java 4c241d1
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java 359e651
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareDisableKerberosServerAction.java 8ab04ff
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareEnableKerberosServerAction.java 84248dc
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/PrepareKerberosIdentitiesServerAction.java fba3eea
ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java 1e89272
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py ca7d2dd
ambari-server/src/test/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessorTest.java d5531a6
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java 8861549
ambari-server/src/test/java/org/apache/ambari/server/topology/ClusterConfigurationRequestTest.java d1886b9
Diff: https://reviews.apache.org/r/42369/diff/
Testing (updated)
-------
Manualled tested:
- creating a cluster via the UI then enabling Kerberos and disabling Kerberos
- creating a cluster via Blueprints then enabling Kerberos and disabling Kerberos
- creating a Kerberized cluster via Blueprints then disabling Kerberos
# Local test results:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:08:31.852s
[INFO] Finished at: Fri Jan 15 19:39:40 EST 2016
[INFO] Final Memory: 56M/1632M
[INFO] ------------------------------------------------------------------------
# Jenkins test results: PENDING
Thanks,
Robert Levas