[GitHub] [kafka] mimaison commented on a change in pull request #11575: KAFKA-13511: Add support for different unix precisions in TimestampConverter SMT

[GitBox <gi...@apache.org>]

mimaison commented on a change in pull request #11575:
URL: https://github.com/apache/kafka/pull/11575#discussion_r811318744



##########
File path: connect/transforms/src/main/java/org/apache/kafka/connect/transforms/TimestampConverter.java
##########
@@ -83,12 +78,36 @@
     private static final String TYPE_TIMESTAMP = "Timestamp";
     private static final Set<String> VALID_TYPES = new HashSet<>(Arrays.asList(TYPE_STRING, TYPE_UNIX, TYPE_DATE, TYPE_TIME, TYPE_TIMESTAMP));
 
+    private static final String UNIX_PRECISION_MILLIS = "milliseconds";
+    private static final String UNIX_PRECISION_MICROS = "microseconds";
+    private static final String UNIX_PRECISION_NANOS = "nanoseconds";
+    private static final String UNIX_PRECISION_SECONDS = "seconds";
+    private static final Set<String> VALID_UNIX_PRECISIONS = new HashSet<>(

Review comment:
       This field is not used, we can remove it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org