You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Sagara Gunathunga (JIRA)" <ji...@apache.org> on 2012/05/08 11:02:16 UTC

[jira] [Created] (AXIS2-5314) loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated.

Sagara Gunathunga  created AXIS2-5314:
-----------------------------------------

             Summary: loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. 
                 Key: AXIS2-5314
                 URL: https://issues.apache.org/jira/browse/AXIS2-5314
             Project: Axis2
          Issue Type: Bug
          Components: kernel
    Affects Versions: 1.6.2
            Reporter: Sagara Gunathunga 
            Assignee: Sagara Gunathunga 
             Fix For: 1.7.0


loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. I found following issues.

1.) Above two methods try to deploy modules/services based on files called services.list and modules.list without depend on repository. AFAIK these concepts were used very beginning and haven't maintain for many years.

2.) These two methods do not respect to deployment features such as hot deployment, hot update etc.

3.) Above methods do not compatible with other deployment approaches and completely ignore Axis2 Deployer architecture. In fact, above method populate Axis2 modules and service within method body themselves instead of calling corresponding Deployer.   

4.) Above methods do not care/related to repository scheduler job.

Also I haven't notice any hint that someone use these methods for last few years. I don't see much advantage promoting another deployment approach ( i. e based on services.list and modules.list) again that we haven't maintain for many years.  Hence I suggest to remove this methods in future releases. For next release let's keep these methods but sync method bodies with current deployment architecture. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] [Commented] (AXIS2-5314) loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated.

Posted by "Sagara Gunathunga (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270453#comment-13270453 ] 

Sagara Gunathunga  commented on AXIS2-5314:
-------------------------------------------

I have reverted r1335402 changes, it seems I don't have an alternative at this moment.  
                
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. 
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-5314
>                 URL: https://issues.apache.org/jira/browse/AXIS2-5314
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.6.2
>            Reporter: Sagara Gunathunga 
>            Assignee: Sagara Gunathunga 
>             Fix For: 1.7.0
>
>
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. I found following issues.
> 1.) Above two methods try to deploy modules/services based on files called services.list and modules.list without depend on repository. AFAIK these concepts were used very beginning and haven't maintain for many years.
> 2.) These two methods do not respect to deployment features such as hot deployment, hot update etc.
> 3.) Above methods do not compatible with other deployment approaches and completely ignore Axis2 Deployer architecture. In fact, above method populate Axis2 modules and service within method body themselves instead of calling corresponding Deployer.   
> 4.) Above methods do not care/related to repository scheduler job.
> Also I haven't notice any hint that someone use these methods for last few years. I don't see much advantage promoting another deployment approach ( i. e based on services.list and modules.list) again that we haven't maintain for many years.  Hence I suggest to remove these methods in future releases. For next release let's keep these methods but sync method bodies with current deployment architecture. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] [Commented] (AXIS2-5314) loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13276682#comment-13276682 ] 

Hudson commented on AXIS2-5314:
-------------------------------

Integrated in Axis2 #1471 (See [https://builds.apache.org/job/Axis2/1471/])
    
     Result = SUCCESS
                
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. 
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-5314
>                 URL: https://issues.apache.org/jira/browse/AXIS2-5314
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.6.2
>            Reporter: Sagara Gunathunga 
>            Assignee: Sagara Gunathunga 
>             Fix For: 1.7.0
>
>
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. I found following issues.
> 1.) Above two methods try to deploy modules/services based on files called services.list and modules.list without depend on repository. AFAIK these concepts were used very beginning and haven't maintain for many years.
> 2.) These two methods do not respect to deployment features such as hot deployment, hot update etc.
> 3.) Above methods do not compatible with other deployment approaches and completely ignore Axis2 Deployer architecture. In fact, above method populate Axis2 modules and service within method body themselves instead of calling corresponding Deployer.   
> 4.) Above methods do not care/related to repository scheduler job.
> Also I haven't notice any hint that someone use these methods for last few years. I don't see much advantage promoting another deployment approach ( i. e based on services.list and modules.list) again that we haven't maintain for many years.  Hence I suggest to remove these methods in future releases. For next release let's keep these methods but sync method bodies with current deployment architecture. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] [Commented] (AXIS2-5314) loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated.

Posted by "Afkham Azeez (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270524#comment-13270524 ] 

Afkham Azeez commented on AXIS2-5314:
-------------------------------------

This is an outdated method IMO. It works only for AAR  & MAR files, and does not work with service deployers. In the olden days, we used to use it when we have a cluster of nodes, make the AAR & MARs accessible over an HTTP URL, and point to that from the worker nodes. This approach does not support hot deployment or hot update, and I don't think this is used by anyone anymore.
                
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. 
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-5314
>                 URL: https://issues.apache.org/jira/browse/AXIS2-5314
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.6.2
>            Reporter: Sagara Gunathunga 
>            Assignee: Sagara Gunathunga 
>             Fix For: 1.7.0
>
>
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. I found following issues.
> 1.) Above two methods try to deploy modules/services based on files called services.list and modules.list without depend on repository. AFAIK these concepts were used very beginning and haven't maintain for many years.
> 2.) These two methods do not respect to deployment features such as hot deployment, hot update etc.
> 3.) Above methods do not compatible with other deployment approaches and completely ignore Axis2 Deployer architecture. In fact, above method populate Axis2 modules and service within method body themselves instead of calling corresponding Deployer.   
> 4.) Above methods do not care/related to repository scheduler job.
> Also I haven't notice any hint that someone use these methods for last few years. I don't see much advantage promoting another deployment approach ( i. e based on services.list and modules.list) again that we haven't maintain for many years.  Hence I suggest to remove these methods in future releases. For next release let's keep these methods but sync method bodies with current deployment architecture. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] [Commented] (AXIS2-5314) loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated.

Posted by "Amila Chinthaka Suriarachchi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270383#comment-13270383 ] 

Amila Chinthaka Suriarachchi commented on AXIS2-5314:
-----------------------------------------------------

IIRC these methods were used to load modules and services from a url. structure of the repository should be same as a normal file system repository url. 

it uses the module.list and services.list files since there is no way to get the existing service or module file names as in a file system. But for an embeded jar it is not the case. 


                
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. 
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-5314
>                 URL: https://issues.apache.org/jira/browse/AXIS2-5314
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.6.2
>            Reporter: Sagara Gunathunga 
>            Assignee: Sagara Gunathunga 
>             Fix For: 1.7.0
>
>
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. I found following issues.
> 1.) Above two methods try to deploy modules/services based on files called services.list and modules.list without depend on repository. AFAIK these concepts were used very beginning and haven't maintain for many years.
> 2.) These two methods do not respect to deployment features such as hot deployment, hot update etc.
> 3.) Above methods do not compatible with other deployment approaches and completely ignore Axis2 Deployer architecture. In fact, above method populate Axis2 modules and service within method body themselves instead of calling corresponding Deployer.   
> 4.) Above methods do not care/related to repository scheduler job.
> Also I haven't notice any hint that someone use these methods for last few years. I don't see much advantage promoting another deployment approach ( i. e based on services.list and modules.list) again that we haven't maintain for many years.  Hence I suggest to remove these methods in future releases. For next release let's keep these methods but sync method bodies with current deployment architecture. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] [Commented] (AXIS2-5314) loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated.

Posted by "Sagara Gunathunga (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270355#comment-13270355 ] 

Sagara Gunathunga  commented on AXIS2-5314:
-------------------------------------------

Most probably modifications I have done in 1335402 will not load repository embedded in a JAR file or repository over any non File URLs. In my earlier attempts I try to keep loading stuff from and URL and call required Deployers instead on creating modules/services inside the method. I can go back to this approach but downside is still we have to use service.list and modules.list files.  Do you have any better idea ?  I don't think we should keep current implantations as it is.   


                
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. 
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-5314
>                 URL: https://issues.apache.org/jira/browse/AXIS2-5314
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.6.2
>            Reporter: Sagara Gunathunga 
>            Assignee: Sagara Gunathunga 
>             Fix For: 1.7.0
>
>
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. I found following issues.
> 1.) Above two methods try to deploy modules/services based on files called services.list and modules.list without depend on repository. AFAIK these concepts were used very beginning and haven't maintain for many years.
> 2.) These two methods do not respect to deployment features such as hot deployment, hot update etc.
> 3.) Above methods do not compatible with other deployment approaches and completely ignore Axis2 Deployer architecture. In fact, above method populate Axis2 modules and service within method body themselves instead of calling corresponding Deployer.   
> 4.) Above methods do not care/related to repository scheduler job.
> Also I haven't notice any hint that someone use these methods for last few years. I don't see much advantage promoting another deployment approach ( i. e based on services.list and modules.list) again that we haven't maintain for many years.  Hence I suggest to remove these methods in future releases. For next release let's keep these methods but sync method bodies with current deployment architecture. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] [Commented] (AXIS2-5314) loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270378#comment-13270378 ] 

Hudson commented on AXIS2-5314:
-------------------------------

Integrated in Axis2 #1441 (See [https://builds.apache.org/job/Axis2/1441/])
    Updated AXIS2-5314 according given description. (Revision 1335402)

     Result = SUCCESS
sagara : 
Files : 
* /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/deployment/DeploymentEngine.java

                
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. 
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-5314
>                 URL: https://issues.apache.org/jira/browse/AXIS2-5314
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.6.2
>            Reporter: Sagara Gunathunga 
>            Assignee: Sagara Gunathunga 
>             Fix For: 1.7.0
>
>
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. I found following issues.
> 1.) Above two methods try to deploy modules/services based on files called services.list and modules.list without depend on repository. AFAIK these concepts were used very beginning and haven't maintain for many years.
> 2.) These two methods do not respect to deployment features such as hot deployment, hot update etc.
> 3.) Above methods do not compatible with other deployment approaches and completely ignore Axis2 Deployer architecture. In fact, above method populate Axis2 modules and service within method body themselves instead of calling corresponding Deployer.   
> 4.) Above methods do not care/related to repository scheduler job.
> Also I haven't notice any hint that someone use these methods for last few years. I don't see much advantage promoting another deployment approach ( i. e based on services.list and modules.list) again that we haven't maintain for many years.  Hence I suggest to remove these methods in future releases. For next release let's keep these methods but sync method bodies with current deployment architecture. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] [Commented] (AXIS2-5314) loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271363#comment-13271363 ] 

Hudson commented on AXIS2-5314:
-------------------------------

Integrated in Axis2 #1444 (See [https://builds.apache.org/job/Axis2/1444/])
    AXIS2-5314 - Since Axis2 transport use these methods it is not possible to remove them but I cleaned those methods as follows.
* Move actual Service/Module build code into corresponding Deployers. Now above methods only mark artifacts for deployment, within the particular Deployer it distinguish file based deployable artifacts and URL based employables and act upon. 
* Documented use cases of URL based deployment.
* Cleaned codes and remove Java5 warring.  

I have tested with JAR file and a HTTP based repository. (Revision 1336090)

     Result = SUCCESS
sagara : 
Files : 
* /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/deployment/DeploymentEngine.java
* /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/deployment/ModuleDeployer.java
* /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/deployment/RepositoryListener.java
* /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/deployment/ServiceDeployer.java
* /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/deployment/WarBasedAxisConfigurator.java
* /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/deployment/repository/util/DeploymentFileData.java
* /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/deployment/repository/util/WSInfoList.java
* /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/util/FaultyServiceData.java

                
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. 
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-5314
>                 URL: https://issues.apache.org/jira/browse/AXIS2-5314
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.6.2
>            Reporter: Sagara Gunathunga 
>            Assignee: Sagara Gunathunga 
>             Fix For: 1.7.0
>
>
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. I found following issues.
> 1.) Above two methods try to deploy modules/services based on files called services.list and modules.list without depend on repository. AFAIK these concepts were used very beginning and haven't maintain for many years.
> 2.) These two methods do not respect to deployment features such as hot deployment, hot update etc.
> 3.) Above methods do not compatible with other deployment approaches and completely ignore Axis2 Deployer architecture. In fact, above method populate Axis2 modules and service within method body themselves instead of calling corresponding Deployer.   
> 4.) Above methods do not care/related to repository scheduler job.
> Also I haven't notice any hint that someone use these methods for last few years. I don't see much advantage promoting another deployment approach ( i. e based on services.list and modules.list) again that we haven't maintain for many years.  Hence I suggest to remove these methods in future releases. For next release let's keep these methods but sync method bodies with current deployment architecture. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] [Resolved] (AXIS2-5314) loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated.

Posted by "Sagara Gunathunga (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sagara Gunathunga  resolved AXIS2-5314.
---------------------------------------

    Resolution: Fixed
    
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. 
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-5314
>                 URL: https://issues.apache.org/jira/browse/AXIS2-5314
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.6.2
>            Reporter: Sagara Gunathunga 
>            Assignee: Sagara Gunathunga 
>             Fix For: 1.7.0
>
>
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. I found following issues.
> 1.) Above two methods try to deploy modules/services based on files called services.list and modules.list without depend on repository. AFAIK these concepts were used very beginning and haven't maintain for many years.
> 2.) These two methods do not respect to deployment features such as hot deployment, hot update etc.
> 3.) Above methods do not compatible with other deployment approaches and completely ignore Axis2 Deployer architecture. In fact, above method populate Axis2 modules and service within method body themselves instead of calling corresponding Deployer.   
> 4.) Above methods do not care/related to repository scheduler job.
> Also I haven't notice any hint that someone use these methods for last few years. I don't see much advantage promoting another deployment approach ( i. e based on services.list and modules.list) again that we haven't maintain for many years.  Hence I suggest to remove these methods in future releases. For next release let's keep these methods but sync method bodies with current deployment architecture. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] [Updated] (AXIS2-5314) loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated.

Posted by "Sagara Gunathunga (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sagara Gunathunga  updated AXIS2-5314:
--------------------------------------

    Description: 
loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. I found following issues.

1.) Above two methods try to deploy modules/services based on files called services.list and modules.list without depend on repository. AFAIK these concepts were used very beginning and haven't maintain for many years.

2.) These two methods do not respect to deployment features such as hot deployment, hot update etc.

3.) Above methods do not compatible with other deployment approaches and completely ignore Axis2 Deployer architecture. In fact, above method populate Axis2 modules and service within method body themselves instead of calling corresponding Deployer.   

4.) Above methods do not care/related to repository scheduler job.

Also I haven't notice any hint that someone use these methods for last few years. I don't see much advantage promoting another deployment approach ( i. e based on services.list and modules.list) again that we haven't maintain for many years.  Hence I suggest to remove these methods in future releases. For next release let's keep these methods but sync method bodies with current deployment architecture. 

  was:
loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. I found following issues.

1.) Above two methods try to deploy modules/services based on files called services.list and modules.list without depend on repository. AFAIK these concepts were used very beginning and haven't maintain for many years.

2.) These two methods do not respect to deployment features such as hot deployment, hot update etc.

3.) Above methods do not compatible with other deployment approaches and completely ignore Axis2 Deployer architecture. In fact, above method populate Axis2 modules and service within method body themselves instead of calling corresponding Deployer.   

4.) Above methods do not care/related to repository scheduler job.

Also I haven't notice any hint that someone use these methods for last few years. I don't see much advantage promoting another deployment approach ( i. e based on services.list and modules.list) again that we haven't maintain for many years.  Hence I suggest to remove this methods in future releases. For next release let's keep these methods but sync method bodies with current deployment architecture. 

    
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. 
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-5314
>                 URL: https://issues.apache.org/jira/browse/AXIS2-5314
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.6.2
>            Reporter: Sagara Gunathunga 
>            Assignee: Sagara Gunathunga 
>             Fix For: 1.7.0
>
>
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. I found following issues.
> 1.) Above two methods try to deploy modules/services based on files called services.list and modules.list without depend on repository. AFAIK these concepts were used very beginning and haven't maintain for many years.
> 2.) These two methods do not respect to deployment features such as hot deployment, hot update etc.
> 3.) Above methods do not compatible with other deployment approaches and completely ignore Axis2 Deployer architecture. In fact, above method populate Axis2 modules and service within method body themselves instead of calling corresponding Deployer.   
> 4.) Above methods do not care/related to repository scheduler job.
> Also I haven't notice any hint that someone use these methods for last few years. I don't see much advantage promoting another deployment approach ( i. e based on services.list and modules.list) again that we haven't maintain for many years.  Hence I suggest to remove these methods in future releases. For next release let's keep these methods but sync method bodies with current deployment architecture. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] [Commented] (AXIS2-5314) loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated.

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270350#comment-13270350 ] 

Andreas Veithen commented on AXIS2-5314:
----------------------------------------

The purpose of this code is to load a repository embedded in a JAR file. I think that if you remove this, some people will not be happy.

Note that that is also the reason why hot deployment/update is not supported: obviously you can't hot update services and modules in a repository embedded in a JAR.
                
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. 
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-5314
>                 URL: https://issues.apache.org/jira/browse/AXIS2-5314
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.6.2
>            Reporter: Sagara Gunathunga 
>            Assignee: Sagara Gunathunga 
>             Fix For: 1.7.0
>
>
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. I found following issues.
> 1.) Above two methods try to deploy modules/services based on files called services.list and modules.list without depend on repository. AFAIK these concepts were used very beginning and haven't maintain for many years.
> 2.) These two methods do not respect to deployment features such as hot deployment, hot update etc.
> 3.) Above methods do not compatible with other deployment approaches and completely ignore Axis2 Deployer architecture. In fact, above method populate Axis2 modules and service within method body themselves instead of calling corresponding Deployer.   
> 4.) Above methods do not care/related to repository scheduler job.
> Also I haven't notice any hint that someone use these methods for last few years. I don't see much advantage promoting another deployment approach ( i. e based on services.list and modules.list) again that we haven't maintain for many years.  Hence I suggest to remove these methods in future releases. For next release let's keep these methods but sync method bodies with current deployment architecture. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


[jira] [Commented] (AXIS2-5314) loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated.

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/AXIS2-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270395#comment-13270395 ] 

Andreas Veithen commented on AXIS2-5314:
----------------------------------------

BTW, the change causes a failure in the transport build.
                
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. 
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-5314
>                 URL: https://issues.apache.org/jira/browse/AXIS2-5314
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.6.2
>            Reporter: Sagara Gunathunga 
>            Assignee: Sagara Gunathunga 
>             Fix For: 1.7.0
>
>
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. I found following issues.
> 1.) Above two methods try to deploy modules/services based on files called services.list and modules.list without depend on repository. AFAIK these concepts were used very beginning and haven't maintain for many years.
> 2.) These two methods do not respect to deployment features such as hot deployment, hot update etc.
> 3.) Above methods do not compatible with other deployment approaches and completely ignore Axis2 Deployer architecture. In fact, above method populate Axis2 modules and service within method body themselves instead of calling corresponding Deployer.   
> 4.) Above methods do not care/related to repository scheduler job.
> Also I haven't notice any hint that someone use these methods for last few years. I don't see much advantage promoting another deployment approach ( i. e based on services.list and modules.list) again that we haven't maintain for many years.  Hence I suggest to remove these methods in future releases. For next release let's keep these methods but sync method bodies with current deployment architecture. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org