You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by shijinkui <gi...@git.apache.org> on 2014/10/10 08:26:23 UTC
[GitHub] spark pull request: [SPARK-3896] checkSpeculatableTasks fask quit ...
GitHub user shijinkui opened a pull request:
https://github.com/apache/spark/pull/2751
[SPARK-3896] checkSpeculatableTasks fask quit loop; checkSpeculatableTasks is expensive
1. invoking checkSpeculatableTasks is expensive, once true then return true
2. import section formatting
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shijinkui/spark fast_quit_loop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/2751.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2751
----
commit 63f60d5ac25b6ad37bfbb63bd93b5072f1f955a1
Author: 玄畅 <ji...@alibaba-inc.com>
Date: 2014-10-10T06:20:51Z
checkSpeculatableTasks fask quit loop; checkSpeculatableTasks is expensive
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3896] Pool#checkSpeculatableTasks fask ...
Posted by shijinkui <gi...@git.apache.org>.
Github user shijinkui commented on the pull request:
https://github.com/apache/spark/pull/2751#issuecomment-59157814
the Pool#checkSpeculatableTasks method named ambiguity.
TaskSetManager.checkSpeculatableTasks:Check for tasks to be speculated and return true if there are any
it put the specula table task to Map: speculatableTasks
bad smell design
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3896] Pool#checkSpeculatableTasks fask ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2751#issuecomment-58617192
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3896] Pool#checkSpeculatableTasks fask ...
Posted by shijinkui <gi...@git.apache.org>.
Github user shijinkui closed the pull request at:
https://github.com/apache/spark/pull/2751
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3896] Pool#checkSpeculatableTasks fask ...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/2751#issuecomment-58760669
Hi @shijinkui, can you provide some motivation / context for this change? The scheduler is a complicated piece of code and even simple changes like this can have unanticipated consequences.
There are two types of Schedulables: pools and TaskSetManagers. It looks like `TaskSetManager.checkSpeculatableTasks()` has the side-effect of updating some internal data-structures in TaskSetManager (such as the `speculatableTasks` HashSet), so your PR's early-termination means that only the first TaskSetManager in the pool will have its fields updated. I haven't checked too closely to see how `checkSpeculatableTasks` is called, but I'm concerned that this change might either cause us to miss out on scheduling some speculatable tasks or may result in more calls / loops through `checkSpeculatableTasks` (meaning that it wouldn't be a huge efficiency gain).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-3896] Pool#checkSpeculatableTasks fask ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/2751#issuecomment-58617197
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org