[jira] [Commented] (PARQUET-1947) DeprecatedParquetInputFormat in CombineFileInputFormat would produce wrong data

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PARQUET-1947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243640#comment-17243640 ] 

ASF GitHub Bot commented on PARQUET-1947:
-----------------------------------------

daijyc commented on pull request #844:
URL: https://github.com/apache/parquet-mr/pull/844#issuecomment-738507900


   Sounds good, added origin or the Cascading RecordReader and InputFormat. Since Cascading also adopt Apache 2.0 License, I think it won't be license issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> DeprecatedParquetInputFormat in CombineFileInputFormat would produce wrong data
> -------------------------------------------------------------------------------
>
>                 Key: PARQUET-1947
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1947
>             Project: Parquet
>          Issue Type: Bug
>          Components: parquet-cascading
>            Reporter: Daniel Dai
>            Priority: Major
>         Attachments: Part1.java
>
>
> When we read parquet file using cascading 2, we observe wrong data in the file boundary when we turn on input combine in cascading (setUseCombinedInput to true).
> This can be reproduced easily with two parquet input files, each containing one record. A simple cascading application (attached) read the two input with setUseCombinedInput(true). What we get is the duplicated record in the first input file and the missing record in the second input file.
> Here is the call sequence to understand what happen after the last record of first input:
> 1. cascading invokes DeprecatedParquetInputFormat.createValue(), that's the last record of first input again
> 2. CombineFileRecordReader invokes RecordReader.next and reach the EOF of first input
> 3. CombineFileRecordReader creates a new DeprecatedParquetInputFormat.RecordReaderWrapper, which creates the new "value" variable containing the first record of second input
> 4. CombineFileRecordReader invokes RecordReader.next on the new RecordReaderWrapper, but since firstRecord flag is on, next does not do anything
> 5. Thus the "value" variable containing the first record of second input is lost, and cascading is reusing the last record of first input



--
This message was sent by Atlassian Jira
(v8.3.4#803005)