You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Doğacan Güney (JIRA)" <ji...@apache.org> on 2008/09/15 10:37:44 UTC
[jira] Created: (HBASE-885) TableMap and TableReduce should be
interfaces
TableMap and TableReduce should be interfaces
---------------------------------------------
Key: HBASE-885
URL: https://issues.apache.org/jira/browse/HBASE-885
Project: Hadoop HBase
Issue Type: Improvement
Components: mapred
Reporter: Doğacan Güney
Priority: Minor
Attachments: tablemr.patch
TableMap and TableReduce are abstract classes which makes it impossible to write a class that maps from and reduce to hbase. IMHO, they should be interfaces since they only define a single and static method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HBASE-885) TableMap and TableReduce should be
interfaces
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631177#action_12631177 ]
stack commented on HBASE-885:
-----------------------------
+1 on this patch (TRUNK is currently frozen).
The only small concern I have is that it will break extant code derived from TableMap. Existing code will have to change so it implements rather than extends TableMap. IMO this is a small inconvenience.
> TableMap and TableReduce should be interfaces
> ---------------------------------------------
>
> Key: HBASE-885
> URL: https://issues.apache.org/jira/browse/HBASE-885
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: mapred
> Reporter: Doğacan Güney
> Priority: Minor
> Attachments: tablemr.patch
>
>
> TableMap and TableReduce are abstract classes which makes it impossible to write a class that maps from and reduce to hbase. IMHO, they should be interfaces since they only define a single and static method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HBASE-885) TableMap and TableReduce should be
interfaces
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack reassigned HBASE-885:
---------------------------
Assignee: Doğacan Güney
> TableMap and TableReduce should be interfaces
> ---------------------------------------------
>
> Key: HBASE-885
> URL: https://issues.apache.org/jira/browse/HBASE-885
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: mapred
> Reporter: Doğacan Güney
> Assignee: Doğacan Güney
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: tablemr.patch
>
>
> TableMap and TableReduce are abstract classes which makes it impossible to write a class that maps from and reduce to hbase. IMHO, they should be interfaces since they only define a single and static method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-885) TableMap and TableReduce should be
interfaces
Posted by "Doğacan Güney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doğacan Güney updated HBASE-885:
--------------------------------
Attachment: tablemr.patch
Simple patch that refactors initJob-s into a TableMapReduceUtil class and makes TableMap and TableReduce interfaces.
TestTableMapReduce is also updated.
> TableMap and TableReduce should be interfaces
> ---------------------------------------------
>
> Key: HBASE-885
> URL: https://issues.apache.org/jira/browse/HBASE-885
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: mapred
> Reporter: Doğacan Güney
> Priority: Minor
> Attachments: tablemr.patch
>
>
> TableMap and TableReduce are abstract classes which makes it impossible to write a class that maps from and reduce to hbase. IMHO, they should be interfaces since they only define a single and static method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HBASE-885) TableMap and TableReduce should be
interfaces
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-885.
-------------------------
Resolution: Fixed
Fix Version/s: 0.19.0
Committed as incompatible change. Thanks for the patch Doğacan. Good stuff.
> TableMap and TableReduce should be interfaces
> ---------------------------------------------
>
> Key: HBASE-885
> URL: https://issues.apache.org/jira/browse/HBASE-885
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: mapred
> Reporter: Doğacan Güney
> Priority: Minor
> Fix For: 0.19.0
>
> Attachments: tablemr.patch
>
>
> TableMap and TableReduce are abstract classes which makes it impossible to write a class that maps from and reduce to hbase. IMHO, they should be interfaces since they only define a single and static method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.