You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Thomas Mueller (JIRA)" <ji...@apache.org> on 2014/01/06 10:59:59 UTC
[jira] [Commented] (OAK-481) SQL2PathEscapingTest failing
[ https://issues.apache.org/jira/browse/OAK-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13862889#comment-13862889 ]
Thomas Mueller commented on OAK-481:
------------------------------------
Yes, with JSR_333-53 the JCR spec is now fixed. The Jackrabbit tests are still in the oak-jcr/pom.xml ignore list:
{code}
org.apache.jackrabbit.core.query.SQL2PathEscapingTest#testGetChildrenNoEscaping
org.apache.jackrabbit.core.query.SQL2PathEscapingTest#testGetChildrenEscapedFull
org.apache.jackrabbit.core.query.SQL2PathEscapingTest#testGetChildrenEscapedNode
{code}
To be able to remove the tests from the ignore list, the tests would need to be changed or removed. Or, as an alternative, we keep them on the ignore list forever.
In either case, this is an incompatibility with Jackrabbit 2.x, and this needs to be documented.
> SQL2PathEscapingTest failing
> ----------------------------
>
> Key: OAK-481
> URL: https://issues.apache.org/jira/browse/OAK-481
> Project: Jackrabbit Oak
> Issue Type: Sub-task
> Components: jcr, query
> Reporter: Alex Parvulescu
> Assignee: Thomas Mueller
> Fix For: 0.16
>
>
> Following the fix of OAK-295, we now have a bunch of new test failures to look at coming from {{SQL2PathEscapingTest}}:
> {{testGetChildrenNoEscaping}} Wrong hit count. expected:<0> but was:<2>
> {{testGetChildrenEscapedFull}}
> {code}
> java.text.ParseException: Query: select * from [nt:base] AS selector where ISCHILDNODE(selector, ['/testroot/a b'])(*); expected: absolute path
> {code}
> {{testGetChildrenEscapedNode}} Wrong hit count. expected:<2> but was:<0>
> Full test trace following:
> {code}
> org.apache.jackrabbit.core.query.SQL2PathEscapingTest
> testGetChildrenNoEscaping(org.apache.jackrabbit.core.query.SQL2PathEscapingTest)
> junit.framework.AssertionFailedError: Wrong hit count. expected:<0> but was:<2>
> at junit.framework.Assert.fail(Assert.java:50)
> at junit.framework.Assert.failNotEquals(Assert.java:287)
> at junit.framework.Assert.assertEquals(Assert.java:67)
> at junit.framework.Assert.assertEquals(Assert.java:199)
> at org.apache.jackrabbit.core.query.AbstractQueryTest.checkResult(AbstractQueryTest.java:92)
> at org.apache.jackrabbit.core.query.SQL2PathEscapingTest.testGetChildrenNoEscaping(SQL2PathEscapingTest.java:67)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
> at junit.framework.TestResult.runProtected(TestResult.java:128)
> at junit.framework.TestResult.run(TestResult.java:113)
> at junit.framework.TestCase.run(TestCase.java:124)
> at org.apache.jackrabbit.test.AbstractJCRTest.run(AbstractJCRTest.java:456)
> at junit.framework.TestSuite.runTest(TestSuite.java:243)
> at junit.framework.TestSuite.run(TestSuite.java:238)
> at junit.framework.TestSuite.runTest(TestSuite.java:243)
> at org.apache.jackrabbit.test.ConcurrentTestSuite.access$001(ConcurrentTestSuite.java:29)
> at org.apache.jackrabbit.test.ConcurrentTestSuite$2.run(ConcurrentTestSuite.java:67)
> at EDU.oswego.cs.dl.util.concurrent.PooledExecutor$Worker.run(Unknown Source)
> at java.lang.Thread.run(Thread.java:662)
> testGetChildrenEscapedFull(org.apache.jackrabbit.core.query.SQL2PathEscapingTest)
> javax.jcr.query.InvalidQueryException: java.text.ParseException: Query: select * from [nt:base] AS selector where ISCHILDNODE(selector, ['/testroot/a b'])(*); expected: absolute path
> at org.apache.jackrabbit.oak.jcr.query.QueryManagerImpl.executeQuery(QueryManagerImpl.java:126)
> at org.apache.jackrabbit.oak.jcr.query.QueryImpl.execute(QueryImpl.java:83)
> at org.apache.jackrabbit.core.query.AbstractQueryTest.executeSQL2Query(AbstractQueryTest.java:269)
> at org.apache.jackrabbit.core.query.SQL2PathEscapingTest.testGetChildrenEscapedFull(SQL2PathEscapingTest.java:81)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
> at junit.framework.TestResult.runProtected(TestResult.java:128)
> at junit.framework.TestResult.run(TestResult.java:113)
> at junit.framework.TestCase.run(TestCase.java:124)
> at org.apache.jackrabbit.test.AbstractJCRTest.run(AbstractJCRTest.java:456)
> at junit.framework.TestSuite.runTest(TestSuite.java:243)
> at junit.framework.TestSuite.run(TestSuite.java:238)
> at junit.framework.TestSuite.runTest(TestSuite.java:243)
> at org.apache.jackrabbit.test.ConcurrentTestSuite.access$001(ConcurrentTestSuite.java:29)
> at org.apache.jackrabbit.test.ConcurrentTestSuite$2.run(ConcurrentTestSuite.java:67)
> at EDU.oswego.cs.dl.util.concurrent.PooledExecutor$Worker.run(Unknown Source)
> at java.lang.Thread.run(Thread.java:662)
> Caused by: java.text.ParseException: Query: select * from [nt:base] AS selector where ISCHILDNODE(selector, ['/testroot/a b'])(*); expected: absolute path
> at org.apache.jackrabbit.oak.query.SQL2Parser.getSyntaxError(SQL2Parser.java:1104)
> at org.apache.jackrabbit.oak.query.SQL2Parser.readAbsolutePath(SQL2Parser.java:458)
> at org.apache.jackrabbit.oak.query.SQL2Parser.parseConditionFunctionIf(SQL2Parser.java:437)
> at org.apache.jackrabbit.oak.query.SQL2Parser.parseCondition(SQL2Parser.java:290)
> at org.apache.jackrabbit.oak.query.SQL2Parser.parseAnd(SQL2Parser.java:273)
> at org.apache.jackrabbit.oak.query.SQL2Parser.parseConstraint(SQL2Parser.java:265)
> at org.apache.jackrabbit.oak.query.SQL2Parser.parse(SQL2Parser.java:127)
> at org.apache.jackrabbit.oak.query.QueryEngineImpl.parseQuery(QueryEngineImpl.java:80)
> at org.apache.jackrabbit.oak.query.QueryEngineImpl.executeQuery(QueryEngineImpl.java:109)
> at org.apache.jackrabbit.oak.query.SessionQueryEngineImpl.executeQuery(SessionQueryEngineImpl.java:73)
> at org.apache.jackrabbit.oak.jcr.query.QueryManagerImpl.executeQuery(QueryManagerImpl.java:120)
> ... 21 more
> testGetChildrenEscapedNode(org.apache.jackrabbit.core.query.SQL2PathEscapingTest)
> junit.framework.AssertionFailedError: Wrong hit count. expected:<2> but was:<0>
> at junit.framework.Assert.fail(Assert.java:50)
> at junit.framework.Assert.failNotEquals(Assert.java:287)
> at junit.framework.Assert.assertEquals(Assert.java:67)
> at junit.framework.Assert.assertEquals(Assert.java:199)
> at org.apache.jackrabbit.core.query.AbstractQueryTest.checkResult(AbstractQueryTest.java:92)
> at org.apache.jackrabbit.core.query.SQL2PathEscapingTest.testGetChildrenEscapedNode(SQL2PathEscapingTest.java:94)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> at java.lang.reflect.Method.invoke(Method.java:597)
> at junit.framework.TestCase.runTest(TestCase.java:168)
> at junit.framework.TestCase.runBare(TestCase.java:134)
> at junit.framework.TestResult$1.protect(TestResult.java:110)
> at junit.framework.TestResult.runProtected(TestResult.java:128)
> at junit.framework.TestResult.run(TestResult.java:113)
> at junit.framework.TestCase.run(TestCase.java:124)
> at org.apache.jackrabbit.test.AbstractJCRTest.run(AbstractJCRTest.java:456)
> at junit.framework.TestSuite.runTest(TestSuite.java:243)
> at junit.framework.TestSuite.run(TestSuite.java:238)
> at junit.framework.TestSuite.runTest(TestSuite.java:243)
> at org.apache.jackrabbit.test.ConcurrentTestSuite.access$001(ConcurrentTestSuite.java:29)
> at org.apache.jackrabbit.test.ConcurrentTestSuite$2.run(ConcurrentTestSuite.java:67)
> at EDU.oswego.cs.dl.util.concurrent.PooledExecutor$Worker.run(Unknown Source)
> at java.lang.Thread.run(Thread.java:662)
> {code}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)