You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2020/11/20 22:57:43 UTC
[commons-imaging] branch master updated (eb68109 -> 2f4adfe)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-imaging.git.
from eb68109 Use Arrays.fill().
new c9f11dc Simplify test.
new 2f4adfe Remove redundant call to super().
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../java/org/apache/commons/imaging/formats/icns/IcnsImageParser.java | 1 -
.../java/org/apache/commons/imaging/formats/ico/IcoImageParser.java | 1 -
.../org/apache/commons/imaging/formats/jpeg/exif/ExifRewriter.java | 1 -
.../java/org/apache/commons/imaging/formats/jpeg/xmp/JpegRewriter.java | 3 +--
.../org/apache/commons/imaging/formats/tiff/write/TiffOutputSet.java | 1 -
.../apache/commons/imaging/formats/tiff/write/TiffOutputSummary.java | 1 -
6 files changed, 1 insertion(+), 7 deletions(-)
[commons-imaging] 01/02: Simplify test.
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-imaging.git
commit c9f11dcf89521f09276c8eab12d58b179f2e93da
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Nov 20 17:52:10 2020 -0500
Simplify test.
---
.../java/org/apache/commons/imaging/formats/jpeg/xmp/JpegRewriter.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/main/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegRewriter.java b/src/main/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegRewriter.java
index 5bb626f..a6279a1 100644
--- a/src/main/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegRewriter.java
+++ b/src/main/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegRewriter.java
@@ -235,7 +235,7 @@ public class JpegRewriter extends BinaryFileParser {
for (final T piece : segments) {
if (piece instanceof JFIFPieceSegment) {
- if (filter.filter((JFIFPieceSegment) piece) ^ !reverse) {
+ if (filter.filter((JFIFPieceSegment) piece) == reverse) {
result.add(piece);
}
} else if (!reverse) {
[commons-imaging] 02/02: Remove redundant call to super().
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-imaging.git
commit 2f4adfee6a286b101c033ae2eddd4ab6722410f4
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Nov 20 17:57:38 2020 -0500
Remove redundant call to super().
---
.../java/org/apache/commons/imaging/formats/icns/IcnsImageParser.java | 1 -
src/main/java/org/apache/commons/imaging/formats/ico/IcoImageParser.java | 1 -
.../java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriter.java | 1 -
.../java/org/apache/commons/imaging/formats/jpeg/xmp/JpegRewriter.java | 1 -
.../org/apache/commons/imaging/formats/tiff/write/TiffOutputSet.java | 1 -
.../org/apache/commons/imaging/formats/tiff/write/TiffOutputSummary.java | 1 -
6 files changed, 6 deletions(-)
diff --git a/src/main/java/org/apache/commons/imaging/formats/icns/IcnsImageParser.java b/src/main/java/org/apache/commons/imaging/formats/icns/IcnsImageParser.java
index 564b028..080dc0c 100644
--- a/src/main/java/org/apache/commons/imaging/formats/icns/IcnsImageParser.java
+++ b/src/main/java/org/apache/commons/imaging/formats/icns/IcnsImageParser.java
@@ -205,7 +205,6 @@ public class IcnsImageParser extends ImageParser {
public final IcnsElement[] icnsElements;
IcnsContents(final IcnsHeader icnsHeader, final IcnsElement[] icnsElements) {
- super();
this.icnsHeader = icnsHeader;
this.icnsElements = icnsElements;
}
diff --git a/src/main/java/org/apache/commons/imaging/formats/ico/IcoImageParser.java b/src/main/java/org/apache/commons/imaging/formats/ico/IcoImageParser.java
index 97827f5..c167d2c 100644
--- a/src/main/java/org/apache/commons/imaging/formats/ico/IcoImageParser.java
+++ b/src/main/java/org/apache/commons/imaging/formats/ico/IcoImageParser.java
@@ -533,7 +533,6 @@ public class IcoImageParser extends ImageParser {
public final IconData[] iconDatas;
ImageContents(final FileHeader fileHeader, final IconData[] iconDatas) {
- super();
this.fileHeader = fileHeader;
this.iconDatas = iconDatas;
}
diff --git a/src/main/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriter.java b/src/main/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriter.java
index d347f59..e292532 100644
--- a/src/main/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriter.java
+++ b/src/main/java/org/apache/commons/imaging/formats/jpeg/exif/ExifRewriter.java
@@ -123,7 +123,6 @@ public class ExifRewriter extends BinaryFileParser {
public final byte[] imageData;
JFIFPieceImageData(final byte[] markerBytes, final byte[] imageData) {
- super();
this.markerBytes = markerBytes;
this.imageData = imageData;
}
diff --git a/src/main/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegRewriter.java b/src/main/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegRewriter.java
index a6279a1..d460ab0 100644
--- a/src/main/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegRewriter.java
+++ b/src/main/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegRewriter.java
@@ -155,7 +155,6 @@ public class JpegRewriter extends BinaryFileParser {
private final byte[] imageData;
JFIFPieceImageData(final byte[] markerBytes, final byte[] imageData) {
- super();
this.markerBytes = markerBytes;
this.imageData = imageData;
}
diff --git a/src/main/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputSet.java b/src/main/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputSet.java
index 28e29d3..0a915d4 100644
--- a/src/main/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputSet.java
+++ b/src/main/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputSet.java
@@ -39,7 +39,6 @@ public final class TiffOutputSet {
}
public TiffOutputSet(final ByteOrder byteOrder) {
- super();
this.byteOrder = byteOrder;
}
diff --git a/src/main/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputSummary.java b/src/main/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputSummary.java
index bc32ed6..61730e2 100644
--- a/src/main/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputSummary.java
+++ b/src/main/java/org/apache/commons/imaging/formats/tiff/write/TiffOutputSummary.java
@@ -44,7 +44,6 @@ class TiffOutputSummary {
public final TiffOutputField itemOffsetField;
OffsetItem(final TiffOutputItem item, final TiffOutputField itemOffsetField) {
- super();
this.itemOffsetField = itemOffsetField;
this.item = item;
}