You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/04 15:59:08 UTC
[GitHub] [tvm] tqchen commented on a change in pull request #6953: Add retry to sockets on EINTR error
tqchen commented on a change in pull request #6953:
URL: https://github.com/apache/tvm/pull/6953#discussion_r536201315
##########
File path: src/support/socket.h
##########
@@ -68,6 +68,23 @@ static inline int poll(struct pollfd* pfd, int nfds, int timeout) {
namespace tvm {
namespace support {
+
+/*!
+ * \brief Call a function and retry if an EINTR error is encountered.
+ * \param f The function to retry.
Review comment:
Add additional rationales here
##########
File path: src/support/socket.h
##########
@@ -68,6 +68,23 @@ static inline int poll(struct pollfd* pfd, int nfds, int timeout) {
namespace tvm {
namespace support {
+
+/*!
+ * \brief Call a function and retry if an EINTR error is encountered.
+ * \param f The function to retry.
+ * \param error_value The error value returned by the call on retry failure.
+ * \return The return code returned by function f or error_value on retry failure.
+ */
+template <typename FUNC>
Review comment:
FUNC => Function (CamelCase)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org