You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "fmxxxx (via GitHub)" <gi...@apache.org> on 2023/12/21 08:32:13 UTC
[PR] Add high concurrency broker thrift server. [doris]
fmxxxx opened a new pull request, #28804:
URL: https://github.com/apache/doris/pull/28804
## Proposed changes
This PR has added TThreadedSelectorServer as the default broker thrift server. TThreadedSelectorServer uses non blocking I/O and a multi-threaded model, which is suitable for handling a large number of concurrent connections and improves performance in high concurrency scenarios.
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Broker) Add high concurrency broker thrift server. [doris]
Posted by "fmxxxx (via GitHub)" <gi...@apache.org>.
fmxxxx commented on PR #28804:
URL: https://github.com/apache/doris/pull/28804#issuecomment-1867158482
run buildall.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Broker) Add high concurrency broker thrift server. [doris]
Posted by "WinkerDu (via GitHub)" <gi...@apache.org>.
WinkerDu commented on code in PR #28804:
URL: https://github.com/apache/doris/pull/28804#discussion_r1434683244
##########
fs_brokers/apache_hdfs_broker/src/main/java/org/apache/doris/broker/hdfs/BrokerBootstrap.java:
##########
@@ -50,7 +50,9 @@ public static void main(String[] args) {
TProcessor tprocessor = new TPaloBrokerService.Processor<TPaloBrokerService.Iface>(
new HDFSBrokerServiceImpl());
- ThriftServer server = new ThriftServer(BrokerConfig.broker_ipc_port, tprocessor);
+ ThriftServer server = new ThriftServer(BrokerConfig.broker_ipc_port,
+ tprocessor,
+ ThriftServer.ThriftServerType.valueOf(BrokerConfig.brokerThriftServerType));
Review Comment:
What would happen if the configured server type does not exist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Broker) Add high concurrency broker thrift server. [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28804:
URL: https://github.com/apache/doris/pull/28804#issuecomment-1867185357
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Add high concurrency broker thrift server. [doris]
Posted by "fmxxxx (via GitHub)" <gi...@apache.org>.
fmxxxx commented on PR #28804:
URL: https://github.com/apache/doris/pull/28804#issuecomment-1865875679
run buildall.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] Add high concurrency broker thrift server. [doris]
Posted by "fmxxxx (via GitHub)" <gi...@apache.org>.
fmxxxx commented on PR #28804:
URL: https://github.com/apache/doris/pull/28804#issuecomment-1865875448
@WinkerDu @morningman @chenlinzhong Please take a review, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Broker) Add high concurrency broker thrift server. [doris]
Posted by "fmxxxx (via GitHub)" <gi...@apache.org>.
fmxxxx closed pull request #28804: [Enhancement](Broker) Add high concurrency broker thrift server.
URL: https://github.com/apache/doris/pull/28804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Broker) Add high concurrency broker thrift server. [doris]
Posted by "fmxxxx (via GitHub)" <gi...@apache.org>.
fmxxxx commented on code in PR #28804:
URL: https://github.com/apache/doris/pull/28804#discussion_r1434661952
##########
fs_brokers/apache_hdfs_broker/src/main/java/org/apache/doris/common/ThriftServer.java:
##########
@@ -35,7 +35,7 @@
*/
public class ThriftServer {
private static final Logger LOG = Logger.getLogger(ThriftServer.class);
- private ThriftServerType type = ThriftServerType.THREAD_POOL;
+ private ThriftServerType type = ThriftServerType.THREADED_SELECTOR;
Review Comment:
sure. done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Enhancement](Broker) Add high concurrency broker thrift server. [doris]
Posted by "WinkerDu (via GitHub)" <gi...@apache.org>.
WinkerDu commented on code in PR #28804:
URL: https://github.com/apache/doris/pull/28804#discussion_r1434049497
##########
fs_brokers/apache_hdfs_broker/src/main/java/org/apache/doris/common/ThriftServer.java:
##########
@@ -35,7 +35,7 @@
*/
public class ThriftServer {
private static final Logger LOG = Logger.getLogger(ThriftServer.class);
- private ThriftServerType type = ThriftServerType.THREAD_POOL;
+ private ThriftServerType type = ThriftServerType.THREADED_SELECTOR;
Review Comment:
maybe we can make it configurable for different scenario?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org