You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/11/16 12:18:46 UTC

[GitHub] [mynewt-nimble] sjanc opened a new pull request #1093: Revert "l2cap: implement echo request-response procedure"

sjanc opened a new pull request #1093:
URL: https://github.com/apache/mynewt-nimble/pull/1093


   This reverts commit ddf8043d1b97f1600aa88c53bd935d0fc9b22c9c.
   
   Unfortunatelly this procedure is not allowed on LE transport. This
   is affecting L2CAP/LE/REJ/BI-02-C [Command Reject – Reserved PDU Codes]
   qualification test case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-nimble] sjanc commented on pull request #1093: Revert "l2cap: implement echo request-response procedure"

Posted by GitBox <gi...@apache.org>.
sjanc commented on pull request #1093:
URL: https://github.com/apache/mynewt-nimble/pull/1093#issuecomment-970235112


   @haukepetersen I think that if you need echo style for testing you probably should implement this on top of L2CAP CoC 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-nimble] sjanc merged pull request #1093: Revert "l2cap: implement echo request-response procedure"

Posted by GitBox <gi...@apache.org>.
sjanc merged pull request #1093:
URL: https://github.com/apache/mynewt-nimble/pull/1093


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [mynewt-nimble] haukepetersen commented on pull request #1093: Revert "l2cap: implement echo request-response procedure"

Posted by GitBox <gi...@apache.org>.
haukepetersen commented on pull request #1093:
URL: https://github.com/apache/mynewt-nimble/pull/1093#issuecomment-977739675


   Too bad :-)
   
   I have definitely missed that part in `BLUETOOTH CORE SPECIFICATION Version 5.3 | Vol 3, Part A: 4. SIGNALING PACKET FORMATS Table 4.2`, no further remarks needed.
   
   When adding that feature, I simply looked at the LL Control PDU description in `Vol 6, Part B, 2.4.2.19` and more important at the `LE Ping procedure` description in `Vol 6, Part B, 5.1.8`. Here it is described, that the LE link layer might indeed send `LL_PING_REQ` packets. Is it possible, that the standard is inconsistent, or is there something else that I have missed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org