[jira] [Commented] (YARN-10106) Yarn logs CLI filtering by application attempt

["Adam Antal (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149277#comment-17149277 ] 

Adam Antal commented on YARN-10106:
-----------------------------------

Thanks for the patch [~mhudaky].

For backward compatibility reasons I think in case when only the containerId is specified let's not populate the appAttemptId - it was null before, and it doesn't matter if we add it to the {{ContainerLogsRequest}}.

The tests look good to me in general, could you please fix them?

> Yarn logs CLI filtering by application attempt
> ----------------------------------------------
>
>                 Key: YARN-10106
>                 URL: https://issues.apache.org/jira/browse/YARN-10106
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn
>            Reporter: Adam Antal
>            Assignee: Hudáky Márton Gyula
>            Priority: Trivial
>         Attachments: YARN-10106.001.patch, YARN-10106.002.patch, YARN-10106.003.patch
>
>
> {{ContainerLogsRequest}} got a new parameter in YARN-10101, which is the {{applicationAttempt}} - we can use this new parameter in Yarn logs CLI as well to filter by application attempt.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org