[commons-bcel] branch master updated: Don't write to System.out in test.

[gg...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git


The following commit(s) were added to refs/heads/master by this push:
     new 4bc6dde  Don't write to System.out in test.
4bc6dde is described below

commit 4bc6ddeab009b392193e771762fbaa0b297ce48d
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Jul 6 20:11:09 2019 -0400

    Don't write to System.out in test.
---
 src/test/java/org/apache/bcel/classfile/ConstantPoolTestCase.java | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/test/java/org/apache/bcel/classfile/ConstantPoolTestCase.java b/src/test/java/org/apache/bcel/classfile/ConstantPoolTestCase.java
index 782bdc4..028f369 100644
--- a/src/test/java/org/apache/bcel/classfile/ConstantPoolTestCase.java
+++ b/src/test/java/org/apache/bcel/classfile/ConstantPoolTestCase.java
@@ -22,6 +22,7 @@ import org.apache.bcel.generic.ConstantPoolGen;
 import org.apache.bcel.generic.InstructionHandle;
 import org.apache.bcel.generic.InstructionList;
 import org.apache.bcel.generic.MethodGen;
+import org.junit.Assert;
 import org.junit.Test;
 
 public class ConstantPoolTestCase extends AbstractTestCase {
@@ -36,7 +37,10 @@ public class ConstantPoolTestCase extends AbstractTestCase {
         for (final Method method : methods) {
             if (method.getName().equals("<init>")) {
                 for (final InstructionHandle instructionHandle : getInstructionHandles(clazz, cp, method)) {
-                    System.out.println(instructionHandle.getInstruction().toString(cp.getConstantPool()));
+                    final String string = instructionHandle.getInstruction().toString(cp.getConstantPool());
+                    Assert.assertNotNull(string);
+                    // TODO Need real assertions.
+                    // System.out.println(string);
                 }
             }
         }