(datafusion-comet) branch main updated: build: Disable some rounding tests when miri is enabled (#1873)

[ag...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

agrove pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion-comet.git


The following commit(s) were added to refs/heads/main by this push:
     new b42cdc90d build: Disable some rounding tests when miri is enabled (#1873)
b42cdc90d is described below

commit b42cdc90d1f1d55c8a2cedd73e4192a208f3fa34
Author: Andy Grove <ag...@apache.org>
AuthorDate: Wed Jun 11 15:58:46 2025 -0600

    build: Disable some rounding tests when miri is enabled (#1873)
---
 native/spark-expr/src/math_funcs/round.rs | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/native/spark-expr/src/math_funcs/round.rs b/native/spark-expr/src/math_funcs/round.rs
index 197909859..9191a88ca 100644
--- a/native/spark-expr/src/math_funcs/round.rs
+++ b/native/spark-expr/src/math_funcs/round.rs
@@ -150,6 +150,7 @@ mod test {
     use datafusion::physical_plan::ColumnarValue;
 
     #[test]
+    #[cfg_attr(miri, ignore)] // rounding does not work when miri enabled
     fn test_round_f32_array() -> Result<()> {
         let args = vec![
             ColumnarValue::Array(Arc::new(Float32Array::from(vec![
@@ -167,6 +168,7 @@ mod test {
     }
 
     #[test]
+    #[cfg_attr(miri, ignore)] // rounding does not work when miri enabled
     fn test_round_f64_array() -> Result<()> {
         let args = vec![
             ColumnarValue::Array(Arc::new(Float64Array::from(vec![
@@ -184,6 +186,7 @@ mod test {
     }
 
     #[test]
+    #[cfg_attr(miri, ignore)] // rounding does not work when miri enabled
     fn test_round_f32_scalar() -> Result<()> {
         let args = vec![
             ColumnarValue::Scalar(ScalarValue::Float32(Some(125.2345))),
@@ -199,6 +202,7 @@ mod test {
     }
 
     #[test]
+    #[cfg_attr(miri, ignore)] // rounding does not work when miri enabled
     fn test_round_f64_scalar() -> Result<()> {
         let args = vec![
             ColumnarValue::Scalar(ScalarValue::Float64(Some(125.2345))),


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org