You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Jasvir Nagra (JIRA)" <ji...@apache.org> on 2008/08/27 21:27:44 UTC
[jira] Created: (SHINDIG-548) Regression: supporting javascript for
caja no longer served
Regression: supporting javascript for caja no longer served
-----------------------------------------------------------
Key: SHINDIG-548
URL: https://issues.apache.org/jira/browse/SHINDIG-548
Project: Shindig
Issue Type: Bug
Components: Features (Javascript), Gadget Rendering Server (Java)
Reporter: Jasvir Nagra
Revision -r '{20080821}' breaks running of cajoled gadgets.
To reproduce:
1. Add "<Require feature="caja"> to SocialHelloWorld.xml
2. Run samplecontainer either with or without "use caja"
3. Note that firebug reports missing ___ object
This is a regression of a fix lryan added which invoked cajoling *and* serving of supporting javascript listed in caja/feature.xml whenever the gadget required feature caja, irrespective of url parameters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-548) Regression: supporting javascript
for caja no longer served
Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627125#action_12627125 ]
Cassie Doll commented on SHINDIG-548:
-------------------------------------
That's what we just moved away from :(
I would really really rather not keep copies of the caja js code in Shindig. I think it is much worse to maintain then pulling the js files out of the jar that maven loads.
php can't use caja anyway... not until we figure out some more general solution for getting gadgets cajoled.
Anyway, this gadget seems to work at the current revision of svn so I think that perhaps this bug was misfiled and was just a problem with a local client.
caja works beautifully!
> Regression: supporting javascript for caja no longer served
> -----------------------------------------------------------
>
> Key: SHINDIG-548
> URL: https://issues.apache.org/jira/browse/SHINDIG-548
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
>
> Revision -r '{20080821}' breaks running of cajoled gadgets.
> To reproduce:
> 1. Add "<Require feature="caja"> to SocialHelloWorld.xml
> 2. Run samplecontainer either with or without "use caja"
> 3. Note that firebug reports missing ___ object
> This is a regression of a fix lryan added which invoked cajoling *and* serving of supporting javascript listed in caja/feature.xml whenever the gadget required feature caja, irrespective of url parameters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-548) Regression: supporting javascript
for caja no longer served
Posted by "Brian Eaton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627120#action_12627120 ]
Brian Eaton commented on SHINDIG-548:
-------------------------------------
I think this is what we want:
1) We stop using maven to manage the Caja dependency.
2) .class files go in a jar, .js files stay separate files.
3) We check all of those in to shindig somewhere.
4) We wrestle with maven until it agrees to use them.
Why do it that way?
- it keeps the java and the javascript in the same place, so it's easy to update both at the same time.
- it lets both the PHP and the Java code depend on the javascript.
> Regression: supporting javascript for caja no longer served
> -----------------------------------------------------------
>
> Key: SHINDIG-548
> URL: https://issues.apache.org/jira/browse/SHINDIG-548
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
>
> Revision -r '{20080821}' breaks running of cajoled gadgets.
> To reproduce:
> 1. Add "<Require feature="caja"> to SocialHelloWorld.xml
> 2. Run samplecontainer either with or without "use caja"
> 3. Note that firebug reports missing ___ object
> This is a regression of a fix lryan added which invoked cajoling *and* serving of supporting javascript listed in caja/feature.xml whenever the gadget required feature caja, irrespective of url parameters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-548) Regression: supporting javascript
for caja no longer served
Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626328#action_12626328 ]
Kevin Brown commented on SHINDIG-548:
-------------------------------------
I'm still seeing the caja code invoked whenever the caja feature is present in the gadget spec (as I expected, since the code that Louis added hasn't been changed or removed).
The bizarro resource loading of the caja js is probably the culprit here.
> Regression: supporting javascript for caja no longer served
> -----------------------------------------------------------
>
> Key: SHINDIG-548
> URL: https://issues.apache.org/jira/browse/SHINDIG-548
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
>
> Revision -r '{20080821}' breaks running of cajoled gadgets.
> To reproduce:
> 1. Add "<Require feature="caja"> to SocialHelloWorld.xml
> 2. Run samplecontainer either with or without "use caja"
> 3. Note that firebug reports missing ___ object
> This is a regression of a fix lryan added which invoked cajoling *and* serving of supporting javascript listed in caja/feature.xml whenever the gadget required feature caja, irrespective of url parameters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-548) Regression: supporting javascript
for caja no longer served
Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cassie Doll resolved SHINDIG-548.
---------------------------------
Resolution: Cannot Reproduce
Assignee: Cassie Doll
> Regression: supporting javascript for caja no longer served
> -----------------------------------------------------------
>
> Key: SHINDIG-548
> URL: https://issues.apache.org/jira/browse/SHINDIG-548
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
> Assignee: Cassie Doll
>
> Revision -r '{20080821}' breaks running of cajoled gadgets.
> To reproduce:
> 1. Add "<Require feature="caja"> to SocialHelloWorld.xml
> 2. Run samplecontainer either with or without "use caja"
> 3. Note that firebug reports missing ___ object
> This is a regression of a fix lryan added which invoked cajoling *and* serving of supporting javascript listed in caja/feature.xml whenever the gadget required feature caja, irrespective of url parameters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-548) Regression: supporting javascript
for caja no longer served
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627980#action_12627980 ]
Chris Chabot commented on SHINDIG-548:
--------------------------------------
"If we split java and javascript then the PHP folks get gadgets.util.sanitizeHtml for free"
+1 !
> Regression: supporting javascript for caja no longer served
> -----------------------------------------------------------
>
> Key: SHINDIG-548
> URL: https://issues.apache.org/jira/browse/SHINDIG-548
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
> Assignee: Cassie Doll
>
> Revision -r '{20080821}' breaks running of cajoled gadgets.
> To reproduce:
> 1. Add "<Require feature="caja"> to SocialHelloWorld.xml
> 2. Run samplecontainer either with or without "use caja"
> 3. Note that firebug reports missing ___ object
> This is a regression of a fix lryan added which invoked cajoling *and* serving of supporting javascript listed in caja/feature.xml whenever the gadget required feature caja, irrespective of url parameters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-548) Regression: supporting javascript
for caja no longer served
Posted by "Jasvir Nagra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626350#action_12626350 ]
Jasvir Nagra commented on SHINDIG-548:
--------------------------------------
Would an alternative way of packaging the required javascript be helpful here? Caja minifies all the javascript it requires into one file (now two files, domita-minified.s and html-sanitizer.js). I'm happy to repack it in an way that makes it easier for Shindig to use, provided we can be sure that updates of caja.jar and the accompanied javascript stay in sync.
> Regression: supporting javascript for caja no longer served
> -----------------------------------------------------------
>
> Key: SHINDIG-548
> URL: https://issues.apache.org/jira/browse/SHINDIG-548
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
>
> Revision -r '{20080821}' breaks running of cajoled gadgets.
> To reproduce:
> 1. Add "<Require feature="caja"> to SocialHelloWorld.xml
> 2. Run samplecontainer either with or without "use caja"
> 3. Note that firebug reports missing ___ object
> This is a regression of a fix lryan added which invoked cajoling *and* serving of supporting javascript listed in caja/feature.xml whenever the gadget required feature caja, irrespective of url parameters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-548) Regression: supporting javascript
for caja no longer served
Posted by "Brian Eaton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627735#action_12627735 ]
Brian Eaton commented on SHINDIG-548:
-------------------------------------
If we split java and javascript then the PHP folks get gadgets.util.sanitizeHtml for free. No java code required for that.
> Regression: supporting javascript for caja no longer served
> -----------------------------------------------------------
>
> Key: SHINDIG-548
> URL: https://issues.apache.org/jira/browse/SHINDIG-548
> Project: Shindig
> Issue Type: Bug
> Components: Features (Javascript), Gadget Rendering Server (Java)
> Reporter: Jasvir Nagra
> Assignee: Cassie Doll
>
> Revision -r '{20080821}' breaks running of cajoled gadgets.
> To reproduce:
> 1. Add "<Require feature="caja"> to SocialHelloWorld.xml
> 2. Run samplecontainer either with or without "use caja"
> 3. Note that firebug reports missing ___ object
> This is a regression of a fix lryan added which invoked cajoling *and* serving of supporting javascript listed in caja/feature.xml whenever the gadget required feature caja, irrespective of url parameters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.