You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ph...@apache.org on 2018/03/31 23:35:12 UTC

[11/12] impala git commit: IMPALA-6760: Fix for py2.7-ism in run-tests.py.

IMPALA-6760: Fix for py2.7-ism in run-tests.py.

A set-literal snuck into run-tests.py in a recent
change. We wish to avoid these to be able to run on
py2.6.

Change-Id: I81928d1880a493b91abb13b3a8149568c9789f66
Reviewed-on: http://gerrit.cloudera.org:8080/9843
Reviewed-by: Philip Zeyliger <ph...@cloudera.com>
Tested-by: Philip Zeyliger <ph...@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/25b2344f
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/25b2344f
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/25b2344f

Branch: refs/heads/2.x
Commit: 25b2344f9315e74ae8d93bed50c90199945f43b3
Parents: e882cbb
Author: Philip Zeyliger <ph...@cloudera.com>
Authored: Wed Mar 28 15:15:42 2018 -0700
Committer: Impala Public Jenkins <im...@gerrit.cloudera.org>
Committed: Fri Mar 30 01:48:38 2018 +0000

----------------------------------------------------------------------
 tests/run-tests.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/impala/blob/25b2344f/tests/run-tests.py
----------------------------------------------------------------------
diff --git a/tests/run-tests.py b/tests/run-tests.py
index 6967b17..9552d0d 100755
--- a/tests/run-tests.py
+++ b/tests/run-tests.py
@@ -80,7 +80,7 @@ class TestCounterPlugin(object):
   # https://docs.pytest.org/en/2.9.2/writing_plugins.html#_pytest.hookspec.pytest_collection_modifyitems
   def pytest_collection_modifyitems(self, items):
       for item in items:
-          self.tests_collected.update({item.nodeid})
+          self.tests_collected.add(item.nodeid)
 
   # link to pytest_runtest_logreport
   # https://docs.pytest.org/en/2.9.2/_modules/_pytest/hookspec.html#pytest_runtest_logreport