You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "huangxiaopingRD (via GitHub)" <gi...@apache.org> on 2026/04/24 15:40:20 UTC
[PR] [SPARK-56620][SQL] Fix stale entries in RuleIdCollection [spark]
huangxiaopingRD opened a new pull request, #55539:
URL: https://github.com/apache/spark/pull/55539
### What changes were proposed in this pull request?
This PR cleans up stale entries in RuleIdCollection by aligning rule names with the current Catalyst codebase.
Specifically, it updates/removes outdated rule FQNs in:
`sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleIdCollection.scala`
**Changes made:**
**Replaced outdated rule name:**
```
org.apache.spark.sql.catalyst.analysis.AnsiTypeCoercion$PromoteStringLiterals
-> org.apache.spark.sql.catalyst.analysis.AnsiTypeCoercion$PromoteStrings
```
**Replaced outdated Analyzer-scoped transpose rule name:**
```
org.apache.spark.sql.catalyst.analysis.Analyzer$ResolveTranspose
-> org.apache.spark.sql.catalyst.analysis.ResolveTranspose
```
**Removed stale rule entries that no longer exist as concrete rules:**
```
Analyzer$ResolveAggAliasInGroupBy
Analyzer$ResolveTables
Analyzer$ResolveTempViews
Analyzer$WrapLateralColumnAliasReference
ResolveDefaultColumns
ResolveGroupByAll
ResolveHigherOrderFunctions
ResolveOrderByAll
SubstituteUnresolvedOrdinals
ApplyCharTypePadding (also not appropriate for this list)
```
### Why are the changes needed?
RuleIdCollection is used to map repeatedly-invoked Catalyst rules to rule IDs for traversal pruning.
Keeping stale/non-existent entries causes drift between metadata and actual rule definitions, and makes maintenance/review harder.
This cleanup keeps RuleIdCollection consistent with current rule implementations and naming after multiple past refactors/renames.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Verified that updated FQNs correspond to existing current rule definitions.
Verified that removed entries are stale and no longer map to active concrete rules.
Performed manual consistency review of the edited RuleIdCollection contents.
No new tests were added because this is an internal metadata cleanup without behavioral or API changes.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56620][SQL] Fix stale entries in RuleIdCollection [spark]
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on code in PR #55539:
URL: https://github.com/apache/spark/pull/55539#discussion_r3212346138
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleIdCollection.scala:
##########
@@ -47,7 +47,6 @@ object RuleIdCollection {
"org.apache.spark.sql.catalyst.analysis.Analyzer$ExtractGenerator" ::
"org.apache.spark.sql.catalyst.analysis.Analyzer$ExtractWindowExpressions" ::
"org.apache.spark.sql.catalyst.analysis.Analyzer$GlobalAggregates" ::
- "org.apache.spark.sql.catalyst.analysis.Analyzer$ResolveAggAliasInGroupBy" ::
Review Comment:
@HyukjinKwon Could you help review this PR again? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56620][SQL] Fix stale entries in RuleIdCollection [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #55539:
URL: https://github.com/apache/spark/pull/55539#issuecomment-5851393467
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56620][SQL] Fix stale entries in RuleIdCollection [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #55539:
URL: https://github.com/apache/spark/pull/55539#discussion_r3144312045
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleIdCollection.scala:
##########
@@ -47,7 +47,6 @@ object RuleIdCollection {
"org.apache.spark.sql.catalyst.analysis.Analyzer$ExtractGenerator" ::
"org.apache.spark.sql.catalyst.analysis.Analyzer$ExtractWindowExpressions" ::
"org.apache.spark.sql.catalyst.analysis.Analyzer$GlobalAggregates" ::
- "org.apache.spark.sql.catalyst.analysis.Analyzer$ResolveAggAliasInGroupBy" ::
Review Comment:
Can we have a simple validation test for this? So that we don't have to repeat this change in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56620][SQL] Fix stale entries in RuleIdCollection [spark]
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on code in PR #55539:
URL: https://github.com/apache/spark/pull/55539#discussion_r3151905420
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/rules/RuleIdCollection.scala:
##########
@@ -47,7 +47,6 @@ object RuleIdCollection {
"org.apache.spark.sql.catalyst.analysis.Analyzer$ExtractGenerator" ::
"org.apache.spark.sql.catalyst.analysis.Analyzer$ExtractWindowExpressions" ::
"org.apache.spark.sql.catalyst.analysis.Analyzer$GlobalAggregates" ::
- "org.apache.spark.sql.catalyst.analysis.Analyzer$ResolveAggAliasInGroupBy" ::
Review Comment:
@HyukjinKwon Thanks for your review. I had added a test to validate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-56620][SQL] Fix stale entries in RuleIdCollection [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #55539: [SPARK-56620][SQL] Fix stale entries in RuleIdCollection
URL: https://github.com/apache/spark/pull/55539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org