[jira] [Comment Edited] (MSHADE-339) Shaded test jar has wrong type "jar"

["Herve Boutemy (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MSHADE-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003699#comment-17003699 ] 

Herve Boutemy edited comment on MSHADE-339 at 12/26/19 5:42 PM:
----------------------------------------------------------------

true, this is one of the few cases where extension is not the same as artifact type [https://maven.apache.org/ref/3.6.3/maven-core/artifact-handlers.html]

one question: is this little code inconsistency breaking anything?

and while at it, shouldn't the "tests" classifier be removed from the call, since it is implicit in "test-jar" type?

is there any test that covers the change? (because I would also fear the the API has a parameter named type but uses it as extension: this is a part of the Maven APIs that has been unclear for years...)


was (Author: hboutemy):
true, this is one of the few cases where extension is not the same as artifact type https://maven.apache.org/ref/3.6.3/maven-core/artifact-handlers.html

one question: is this little code inconsistency breaking anything?

and while at it, shouldn't the "tests" classifier be removed from the call, since it is implicit in "test-jar" type?

is there any test that covers the change?

> Shaded test jar has wrong type "jar"
> ------------------------------------
>
>                 Key: MSHADE-339
>                 URL: https://issues.apache.org/jira/browse/MSHADE-339
>             Project: Maven Shade Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2, 3.2.2
>            Reporter: Peter De Maeyer
>            Priority: Minor
>             Fix For: 3.2.2
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The shaded test jar has the wrong type "jar".
> It should be "test-jar".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)