You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/29 21:58:57 UTC
[GitHub] [spark] jlherzberg opened a new pull request #31999: [WIP] add column names to column number mismatch runtimeerror
jlherzberg opened a new pull request #31999:
URL: https://github.com/apache/spark/pull/31999
### What changes were proposed in this pull request?
Adds names of columns returned by function to error message.
Change suggested here http://apache-spark-user-list.1001560.n3.nabble.com/Error-Message-Suggestion-td39884.html
### Why are the changes needed?
In the error message, the number of returned columns and number of expected columns are returned, but with the names of the actual columns returned, the error would be much more helpful and easier to debug.
### Does this PR introduce _any_ user-facing change?
Users would see the changed error when developing.
### How was this patch tested?
No new tests. Passes related tests on my machine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on a change in pull request #31999: Add column names to column number mismatch runtimeerror
Posted by GitBox <gi...@apache.org>.
Yikun commented on a change in pull request #31999:
URL: https://github.com/apache/spark/pull/31999#discussion_r607907149
##########
File path: python/pyspark/worker.py
##########
@@ -141,7 +141,8 @@ def wrapped(left_key_series, left_value_series, right_key_series, right_value_se
raise RuntimeError(
"Number of columns of the returned pandas.DataFrame "
"doesn't match specified schema. "
- "Expected: {} Actual: {}".format(len(return_type), len(result.columns)))
+ "Expected: {} Actual: {}"
Review comment:
```suggestion
"Expected: {} Actual: {} "
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #31999: Add column names to column number mismatch runtimeerror
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #31999:
URL: https://github.com/apache/spark/pull/31999#issuecomment-881085921
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31999: [WIP] add column names to column number mismatch runtimeerror
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31999:
URL: https://github.com/apache/spark/pull/31999#issuecomment-809741800
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #31999: Add column names to column number mismatch runtimeerror
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #31999:
URL: https://github.com/apache/spark/pull/31999
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org