You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/23 04:55:51 UTC
[GitHub] [incubator-tvm] tqchen commented on a change in pull request #6527: [FIX] fix the python script for building resnet (#6526)
tqchen commented on a change in pull request #6527:
URL: https://github.com/apache/incubator-tvm/pull/6527#discussion_r493185840
##########
File path: rust/tvm/examples/resnet/build.rs
##########
@@ -23,6 +23,7 @@ use std::{path::Path, process::Command};
fn main() -> Result<()> {
let output = Command::new("python3")
.arg(concat!(env!("CARGO_MANIFEST_DIR"), "/src/build_resnet.py"))
+ //.arg(&format!("--pretrained"))
Review comment:
Thanks @intheworld, I also agree that we should keep the pretrained flag as it is
##########
File path: rust/tvm/examples/resnet/build.rs
##########
@@ -23,6 +23,7 @@ use std::{path::Path, process::Command};
fn main() -> Result<()> {
let output = Command::new("python3")
.arg(concat!(env!("CARGO_MANIFEST_DIR"), "/src/build_resnet.py"))
+ //.arg(&format!("--pretrained"))
Review comment:
Thanks @intheworld, I also agree that we should keep the pretrained flag as it is instead of comment it out
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org