You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by "Lewis John McGibbney (JIRA)" <ji...@apache.org> on 2012/05/09 16:09:49 UTC
[jira] [Created] (NUTCH-1362) Fix error handling of urls with empty
fields
Lewis John McGibbney created NUTCH-1362:
-------------------------------------------
Summary: Fix error handling of urls with empty fields
Key: NUTCH-1362
URL: https://issues.apache.org/jira/browse/NUTCH-1362
Project: Nutch
Issue Type: Bug
Affects Versions: nutchgora
Reporter: Lewis John McGibbney
Fix For: nutchgora
Within o.a.n.util.TableUtil.reverseAppendSplits() a simple if (split.length > 0) block enables us to address this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (NUTCH-1362) Fix error handling of urls with empty
fields
Posted by "Ferdy Galema (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ferdy Galema updated NUTCH-1362:
--------------------------------
Attachment: NUTCH-1362.patch
Hey Lewis,
This patches fixes the problem and makes the reversing a bit faster by using StringUtils.split instead of String.split. (The latter compiles a regular expression every time a split is done. That's a bit excessive for simple dot and colon splitting.)
Tested and verified.
> Fix error handling of urls with empty fields
> ---------------------------------------------
>
> Key: NUTCH-1362
> URL: https://issues.apache.org/jira/browse/NUTCH-1362
> Project: Nutch
> Issue Type: Bug
> Affects Versions: nutchgora
> Reporter: Lewis John McGibbney
> Fix For: nutchgora
>
> Attachments: NUTCH-1362.patch
>
>
> Within o.a.n.util.TableUtil.reverseAppendSplits() a simple if (split.length > 0) block enables us to address this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (NUTCH-1362) Fix error handling of urls with empty
fields
Posted by "Ferdy Galema (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ferdy Galema closed NUTCH-1362.
-------------------------------
Resolution: Fixed
Done! Thanks.
> Fix error handling of urls with empty fields
> ---------------------------------------------
>
> Key: NUTCH-1362
> URL: https://issues.apache.org/jira/browse/NUTCH-1362
> Project: Nutch
> Issue Type: Bug
> Affects Versions: nutchgora
> Reporter: Lewis John McGibbney
> Fix For: nutchgora
>
> Attachments: NUTCH-1362.patch
>
>
> Within o.a.n.util.TableUtil.reverseAppendSplits() a simple if (split.length > 0) block enables us to address this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1362) Fix error handling of urls with
empty fields
Posted by "Ferdy Galema (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273129#comment-13273129 ]
Ferdy Galema commented on NUTCH-1362:
-------------------------------------
Btw this is a duplicate of NUTCH-1077.
> Fix error handling of urls with empty fields
> ---------------------------------------------
>
> Key: NUTCH-1362
> URL: https://issues.apache.org/jira/browse/NUTCH-1362
> Project: Nutch
> Issue Type: Bug
> Affects Versions: nutchgora
> Reporter: Lewis John McGibbney
> Fix For: nutchgora
>
> Attachments: NUTCH-1362.patch
>
>
> Within o.a.n.util.TableUtil.reverseAppendSplits() a simple if (split.length > 0) block enables us to address this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1362) Fix error handling of urls with
empty fields
Posted by "Lewis John McGibbney (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273143#comment-13273143 ]
Lewis John McGibbney commented on NUTCH-1362:
---------------------------------------------
+1 to commit Ferdy. I am happy with this and simplification.
> Fix error handling of urls with empty fields
> ---------------------------------------------
>
> Key: NUTCH-1362
> URL: https://issues.apache.org/jira/browse/NUTCH-1362
> Project: Nutch
> Issue Type: Bug
> Affects Versions: nutchgora
> Reporter: Lewis John McGibbney
> Fix For: nutchgora
>
> Attachments: NUTCH-1362.patch
>
>
> Within o.a.n.util.TableUtil.reverseAppendSplits() a simple if (split.length > 0) block enables us to address this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (NUTCH-1362) Fix error handling of urls with
empty fields
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273829#comment-13273829 ]
Hudson commented on NUTCH-1362:
-------------------------------
Integrated in Nutch-nutchgora #250 (See [https://builds.apache.org/job/Nutch-nutchgora/250/])
NUTCH-1362 Fix error handling of urls with empty fields (Revision 1337091)
Result = SUCCESS
ferdy :
Files :
* /nutch/branches/nutchgora/CHANGES.txt
* /nutch/branches/nutchgora/src/java/org/apache/nutch/util/TableUtil.java
> Fix error handling of urls with empty fields
> ---------------------------------------------
>
> Key: NUTCH-1362
> URL: https://issues.apache.org/jira/browse/NUTCH-1362
> Project: Nutch
> Issue Type: Bug
> Affects Versions: nutchgora
> Reporter: Lewis John McGibbney
> Fix For: nutchgora
>
> Attachments: NUTCH-1362.patch
>
>
> Within o.a.n.util.TableUtil.reverseAppendSplits() a simple if (split.length > 0) block enables us to address this issue.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira