You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Joseph Wu (JIRA)" <ji...@apache.org> on 2017/09/03 12:59:02 UTC
[jira] [Commented] (MESOS-6721) Group source files into folders for
IDE's
[ https://issues.apache.org/jira/browse/MESOS-6721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16151800#comment-16151800 ]
Joseph Wu commented on MESOS-6721:
----------------------------------
Reviews that removed the non-working existing source grouping logic:
{code}
commit b8d187f338efb27d11f85921955dc0ee93ae501a
Author: Andrew Schwartzmeyer <an...@schwartzmeyer.com>
Date: Sat Sep 2 09:34:32 2017 -0700
CMake: Removed `GroupSource.cmake`.
While we want to group sources, this current solution is not
working as intended. We will consider looking into grouping
source again in future.
Review: https://reviews.apache.org/r/61351/
commit 96866d2c6105cda479a33371401377a77281a0e9
Author: Andrew Schwartzmeyer <an...@schwartzmeyer.com>
Date: Sat Sep 2 09:07:34 2017 -0700
CMake: Removed `GroupSource` usage from `libprocess`.
Source grouping is a cosmetic change that only has an effect if
you load this project into an IDE (such as XCode or Visual Studio).
The existing source grouping is brittle and is not vital for the
CMake build system MVP, so we are removing it to reduce code churn.
Review: https://reviews.apache.org/r/61350/
commit ae778e46ecdb8096ae8d69e584a69114d2226fd0
Author: Andrew Schwartzmeyer <an...@schwartzmeyer.com>
Date: Mon Aug 7 18:09:48 2017 -0700
CMake: Removed `GroupSource` from `stout`.
Source grouping is a cosmetic change that only has an effect if
you load this project into an IDE (such as XCode or Visual Studio).
The existing source grouping is brittle and is not vital for the
CMake build system MVP, so we are removing it to reduce code churn.
Review: https://reviews.apache.org/r/61287/
{code}
> Group source files into folders for IDE's
> -----------------------------------------
>
> Key: MESOS-6721
> URL: https://issues.apache.org/jira/browse/MESOS-6721
> Project: Mesos
> Issue Type: Bug
> Components: cmake
> Reporter: Alex Clemmer
> Assignee: Alex Clemmer
> Labels: cmake, microsoft
>
> CMake has good facilities for organizing source files in a project into folders, but we don't really make use of them. This is especially bad for IDEs like XCode and Visual Studio, where the source files will just end up in a folder with literally everything that's included.
> For every executable and library we make, we should do something like this (and it might be wrong, because my memory is hazy here):
> ```
> set_property(TARGET ${AGENT_TARGET} PROPERTY FOLDER "src/slave")
> ```
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)