[jira] [Commented] (CXF-5938) LuceneQueryVisitor is not reusable / not thread-safe

["Andriy Redko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-5938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14115273#comment-14115273 ] 

Andriy Redko commented on CXF-5938:
-----------------------------------

Hi Sergey,

Just pushed the fix and tests for this issue. It involved a bit more work (in order to escape 'reset'-like method introduction) because it turned out that visit() method could be called recursively as part of complex search condition processing. Please take a look whenever you have time, I would very appreciate your feedback. 

Thanks!

Best Regards,
    Andriy Redko

> LuceneQueryVisitor is not reusable / not thread-safe
> ----------------------------------------------------
>
>                 Key: CXF-5938
>                 URL: https://issues.apache.org/jira/browse/CXF-5938
>             Project: CXF
>          Issue Type: Bug
>          Components: Integration
>    Affects Versions: 3.0.1
>            Reporter: Andriy Redko
>            Assignee: Andriy Redko
>            Priority: Minor
>             Fix For: 3.0.2
>
>
> LuceneQueryVisitor class is not really reusable in current implementation: it keeps the state of all parsed queries (which is generally fine) but it groups them by property name, returning the first query from the list all the time. That means running two search criteria like 'ct=java' and 'ct=websockets' causes the result of 'ct=java' to be returned in both cases (very easy reproducible).



--
This message was sent by Atlassian JIRA
(v6.2#6252)