You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/06/11 08:38:52 UTC
[GitHub] [kafka] mdedetrich opened a new pull request, #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16
mdedetrich opened a new pull request, #12284:
URL: https://github.com/apache/kafka/pull/12284
This PR updates from Scala 2.12.15 to 2.12.16. Since its a binary compatible change there shouldn't be any problems.
### Committer Checklist (excluded from commit message)
- [X] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [X] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mdedetrich commented on pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #12284:
URL: https://github.com/apache/kafka/pull/12284#issuecomment-1158708791
> Yes, kafka is unaffacted by it now, but it could be affected in the future.
The fix for this has already been merged into Scala and it will be included in the 2.12.17 release which is being expedited. So while its theoritically possible Kafka could be effected by this change if you do write very specific Scala code that hits this bug, i.e.
```scala
public class C {
public class I { public class J {} }
public void t(I.J j) {}
}
```
Its highly unlikely this would happen before Scala 2.12.17 is released (current eta 2-3 months) and the appropriate version bump is put into Kafka
> If there's a clear benefit for going with 2.12.16, we can go ahead though. Is there?
So according to the release notes this release of Scala mainly addressed JDK related issues, i.e.
> This release improves compatibility with recent JDKs:
> Use ASM 9.3, enabling JDK 19 support (https://github.com/scala/scala/pull/10000)
> Make -target support JDK 8 through 19 (and deprecate 5 through 7) (https://github.com/scala/scala/pull/9916)
> Fix codegen for MethodHandle.invoke (et al) under JDK 17 -release (https://github.com/scala/scala/pull/9930)
> Deprecate AnyVal#formatted(formatString), to avoid conflict with JDK 15+ method (https://github.com/scala/scala/pull/9783)
So I would there is clear benefit for people that happen to be using newer JDK versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mdedetrich commented on pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #12284:
URL: https://github.com/apache/kafka/pull/12284#issuecomment-1250062919
Scala 2.12.17 just came out so I have rebased the PR with the new Scala version. This also means that all of the qualms mentioned in https://github.com/apache/kafka/pull/12284#issuecomment-1158283064 aren't relevant anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16
Posted by GitBox <gi...@apache.org>.
mimaison commented on PR #12284:
URL: https://github.com/apache/kafka/pull/12284#issuecomment-1219339690
Ah yes, you're right! My bad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.17 [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison closed pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.17
URL: https://github.com/apache/kafka/pull/12284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.17 [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #12284:
URL: https://github.com/apache/kafka/pull/12284#issuecomment-1923750020
We upgrade to Scala 2.12.18 in https://github.com/apache/kafka/commit/dfaae317b82035323ba9c693b3ad7f02a6a58395. Closing this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mdedetrich commented on pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #12284:
URL: https://github.com/apache/kafka/pull/12284#issuecomment-1156984238
> Is there something you're looking for in 2.12.16?
So I already had a detailed look into this, it only occurs at compile time (see https://github.com/scala/bug/issues/12605#issuecomment-1151427077) which means that unless you get that specifically mentioned compile error there is no adverse effect. You can see the precise details with the linked ticket at https://github.com/scala/bug/issues/12605 but in summary Kafka is completely unaffected by this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mdedetrich commented on pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #12284:
URL: https://github.com/apache/kafka/pull/12284#issuecomment-1156251953
@divijvaidya Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mimaison commented on pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16
Posted by GitBox <gi...@apache.org>.
mimaison commented on PR #12284:
URL: https://github.com/apache/kafka/pull/12284#issuecomment-1219323255
Can you also update `bin/kafka-run-class.sh` and `bin/windows/kafka-run-class.bat`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mdedetrich commented on a diff in pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on code in PR #12284:
URL: https://github.com/apache/kafka/pull/12284#discussion_r898217940
##########
docs/upgrade.html:
##########
@@ -59,6 +59,9 @@ <h4><a id="upgrade_3_2_0" href="#upgrade_3_2_0">Upgrading to 3.2.0 from any vers
(or to take advantage of <a href="#upgrade_11_exactly_once_semantics">exactly once semantics</a>),
the newer Java clients must be used.
</li>
+ <li>Upgrade from Scala 2.12.15 to 2.12.16. See https://github.com/scala/scala/releases/tag/v2.12.16 for release
Review Comment:
I removed the release notes and forced pushed the branch. The PR description contains the release notes instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16
Posted by GitBox <gi...@apache.org>.
ijuma commented on PR #12284:
URL: https://github.com/apache/kafka/pull/12284#issuecomment-1156981130
I notice there's a regression:
> Scala 2.12.16 contains a https://github.com/scala/bug/issues/12605 that was discovered after the artifacts were published. Only mixed compilation of Scala and Java source files together is affected, and only when the Scala code contains references to certain nested classes in the Java sources. The problem manifests as a compile-time type error. Follow link for details and workarounds. We'll fix the problem in Scala 2.12.17 which we expect to release in a few months.
Is there something you're looking for in 2.12.16?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16
Posted by GitBox <gi...@apache.org>.
ijuma commented on PR #12284:
URL: https://github.com/apache/kafka/pull/12284#issuecomment-1158283064
@mdedetrich Yes, kafka is unaffacted by it now, but it could be affected in the future. If there's a clear benefit for going with 2.12.16, we can go ahead though. Is there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mdedetrich commented on pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #12284:
URL: https://github.com/apache/kafka/pull/12284#issuecomment-1219328536
@mimaison
> Can you also update bin/kafka-run-class.sh and bin/windows/kafka-run-class.bat?
I just checked those files and it seems that this is not necessary because we are not updating the latest Scala series but the one behind it. Kafka supports Scala 2.13.x and 2.12.x with 2.13.x being the default which is the version being referenced in `bin/kafka-run-class.sh`/`bin/windows/kafka-run-class.bat`. This PR however only updates Scala 2.12.x (specifically 2.12.5 to 2.12.16)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on a diff in pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on code in PR #12284:
URL: https://github.com/apache/kafka/pull/12284#discussion_r897932645
##########
docs/upgrade.html:
##########
@@ -59,6 +59,9 @@ <h4><a id="upgrade_3_2_0" href="#upgrade_3_2_0">Upgrading to 3.2.0 from any vers
(or to take advantage of <a href="#upgrade_11_exactly_once_semantics">exactly once semantics</a>),
the newer Java clients must be used.
</li>
+ <li>Upgrade from Scala 2.12.15 to 2.12.16. See https://github.com/scala/scala/releases/tag/v2.12.16 for release
Review Comment:
Is this comment at the right place? Currently, it seems like that it is under the section "For a rolling upgrade" which contains instructions for Kafka cluster administrators to handle version upgrades which should have nothing to do with scala version since scala is bundled as a dependency independent of the scala version on the OS.
@ijuma will know more about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on PR #12284:
URL: https://github.com/apache/kafka/pull/12284#issuecomment-1156421242
cc: @ijuma (since you seem have performed scala upgrades in the past)
The test failures do not seem related to this code change to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a diff in pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16
Posted by GitBox <gi...@apache.org>.
ijuma commented on code in PR #12284:
URL: https://github.com/apache/kafka/pull/12284#discussion_r898205328
##########
docs/upgrade.html:
##########
@@ -59,6 +59,9 @@ <h4><a id="upgrade_3_2_0" href="#upgrade_3_2_0">Upgrading to 3.2.0 from any vers
(or to take advantage of <a href="#upgrade_11_exactly_once_semantics">exactly once semantics</a>),
the newer Java clients must be used.
</li>
+ <li>Upgrade from Scala 2.12.15 to 2.12.16. See https://github.com/scala/scala/releases/tag/v2.12.16 for release
Review Comment:
We don't usually add patch upgrades to the release notes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] divijvaidya commented on pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16
Posted by GitBox <gi...@apache.org>.
divijvaidya commented on PR #12284:
URL: https://github.com/apache/kafka/pull/12284#issuecomment-1156237309
@mdedetrich could you please re-run the tests (by pushing another commit or by rebasing from trunk & force pushing). It would be ideal if we have a clean test run (with known flaky failures) before we approve this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mdedetrich commented on a diff in pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on code in PR #12284:
URL: https://github.com/apache/kafka/pull/12284#discussion_r898217940
##########
docs/upgrade.html:
##########
@@ -59,6 +59,9 @@ <h4><a id="upgrade_3_2_0" href="#upgrade_3_2_0">Upgrading to 3.2.0 from any vers
(or to take advantage of <a href="#upgrade_11_exactly_once_semantics">exactly once semantics</a>),
the newer Java clients must be used.
</li>
+ <li>Upgrade from Scala 2.12.15 to 2.12.16. See https://github.com/scala/scala/releases/tag/v2.12.16 for release
Review Comment:
I removed the these release and forced pushed the branch. The PR description contains the release notes instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mdedetrich commented on pull request #12284: KAFKA-13980: Upgrade from Scala 2.12.15 to 2.12.16
Posted by GitBox <gi...@apache.org>.
mdedetrich commented on PR #12284:
URL: https://github.com/apache/kafka/pull/12284#issuecomment-1243496402
@ijuma @mimaison Any chance of a review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org