You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/16 06:49:44 UTC
[GitHub] [superset] kevinwenglu opened a new issue #15729: Modifying a connection's meta data not working after creation
kevinwenglu opened a new issue #15729:
URL: https://github.com/apache/superset/issues/15729
Go to /databaseview/list/. Add a new database connection. A new database connection is created. Click on the edit button on the right and bring up the modal for the connection. Change something and click save button.
I expected that the changes is updated and the modal should disappear.
However, A error message pops up and the modal stays.
(please complete the following information):
I took a snapshot from master at May, pretty closed to 1.2. I saw the same code in 1.2 too. It throws an error for an existing connection with parameters at line 262 in the file: https://github.com/apache/superset/blob/latest/superset/databases/schemas.py
There is an exception for Mysql because Mysql is the direct dependent of BaseParametersMixin.
I'm using python 3.8.10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kevinwenglu commented on issue #15729: Modifying a connection's meta data not working after creation
Posted by GitBox <gi...@apache.org>.
kevinwenglu commented on issue #15729:
URL: https://github.com/apache/superset/issues/15729#issuecomment-881684143
There is no actual trace stack on the page because the frontend captures that and display as an error message, but the screenshot shows the stack until the exception is raised.
As I said, we captured the master in May. I haven’t had time to test 1.2 yet, but seems like the logic is the same. I also see that the superset/databases/schemas.py in 1.3 and the current master is using the different condition to check against the validity of the engine spec.
https://github.com/apache/superset/blob/master/superset/databases/schemas.py
https://github.com/apache/superset/blob/1.3/superset/databases/schemas.py
https://github.com/apache/superset/blob/1.2/superset/databases/schemas.py
[superset.databases.schemas.in_may.py.txt](https://github.com/apache/superset/files/6833085/superset.databases.schemas.in_may.py.txt)
[superset.databases.schemas.1.2.py.txt](https://github.com/apache/superset/files/6833086/superset.databases.schemas.1.2.py.txt)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on issue #15729: Modifying a connection's meta data not working after creation
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #15729:
URL: https://github.com/apache/superset/issues/15729#issuecomment-881228856
Cannot repro against the latest master or 1.2. Can you please post more info and confirm that this is an issue with latest master or 1.2? A “snapshot from master at May” is not enough info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai edited a comment on issue #15729: Modifying a connection's meta data not working after creation
Posted by GitBox <gi...@apache.org>.
nytai edited a comment on issue #15729:
URL: https://github.com/apache/superset/issues/15729#issuecomment-881228856
Cannot repro against the latest master or 1.2. Can you please post more info and confirm that this is an issue with latest master or 1.2? A “snapshot from master at May” is not specific enough, as this may have only been a issue for a brief period
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai closed issue #15729: Modifying a connection's meta data not working after creation
Posted by GitBox <gi...@apache.org>.
nytai closed issue #15729:
URL: https://github.com/apache/superset/issues/15729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on issue #15729: Modifying a connection's meta data not working after creation
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #15729:
URL: https://github.com/apache/superset/issues/15729#issuecomment-887104866
cannot repro in 1.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org