You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Tim Thorpe <tt...@ca.ibm.com> on 2017/04/03 11:34:45 UTC
Re: Review Request 58002: AMBARI-20592 ServicePresences check should
also check for services dropped from a release
> On March 28, 2017, 9:01 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/checks/ServicePresenceCheck.java
> > Lines 161 (patched)
> > <https://reviews.apache.org/r/58002/diff/1/?file=1677728#file1677728line161>
> >
> > Are these all removed services, or only the ones that participate in the orchestration?
> >
> > What happens if a service, say AMS or SmartSense is dropped from the stack, doesn't participate in EU/RU?
> >
> > Then the PreChecks shouldn't fail because of it.
>
> Di Li wrote:
> Hello Alejandro,
>
> I want all services to be checked, because when a service is dropped from a stack, it's gone and doesn't matter if it;s included in the upgrade orchestration.
>
> Alejandro Fernandez wrote:
> I'm asking if we need to filter out for only services that participate in the orchestration
If services are installed which are dropped in the next stack version, you will end up in a broken situation after the upgrade. It is better to make sure the installed services will still be functional prior to the upgrade. This is especially true for services during rolling upgrade where the new stack version is used for the service check. This will find that the service no longer exists and will fail the execution. The alternative would be to add the service to the exclude list but even then you have an unclean installed stack.
I'm not even sure if after the upgrade, you will be able to effectively remove the service. You may need to clean up the DB.
- Tim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58002/#review170340
-----------------------------------------------------------
On March 28, 2017, 8:04 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58002/
> -----------------------------------------------------------
>
> (Updated March 28, 2017, 8:04 p.m.)
>
>
> Review request for Ambari and Tim Thorpe.
>
>
> Bugs: AMBARI-20592
> https://issues.apache.org/jira/browse/AMBARI-20592
>
>
> Repository: ambari
>
>
> Description
> -------
>
> ServicePresence check currently checks the following two cases
> 1. services that do not support upgrade, and must be reinstalled post EU/RU
> 2. services replaced by other services in the new release, where the old service must be dropped before EU/RU, and the replacement can be added post the stack upgrade.
> The JIRA is to add one more use case to the check, that;s to check for services dropped from the new release (end of life)
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java 71c5857
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicePresenceCheck.java 4642b88
> ambari-server/src/test/java/org/apache/ambari/server/checks/ServicePresenceCheckTest.java 03b0e81
>
>
> Diff: https://reviews.apache.org/r/58002/diff/1/
>
>
> Testing
> -------
>
> unit tests
> patch Ambari trunk cluster, update upgrade.xml to include for example YARN as a removed service, run EU/RU, verify precheck fails and couldn't proceed (expected)
>
>
> Thanks,
>
> Di Li
>
>