You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/02/07 21:13:09 UTC
[GitHub] [trafficserver] rob05c opened a new pull request #8651: Add parent_select plugin strategy caching
rob05c opened a new pull request #8651:
URL: https://github.com/apache/trafficserver/pull/8651
Without this, large production strategies.yaml files with thousands
of remaps take hours to load, because each remap independently
loads and parses the strategies.yaml file.
This makes the plugin reuse the parsed object if multiple remaps
use the same file. On reload, files are loaded again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] rob05c merged pull request #8651: Add parent_select plugin strategy caching
Posted by GitBox <gi...@apache.org>.
rob05c merged pull request #8651:
URL: https://github.com/apache/trafficserver/pull/8651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] ywkaras commented on a change in pull request #8651: Add parent_select plugin strategy caching
Posted by GitBox <gi...@apache.org>.
ywkaras commented on a change in pull request #8651:
URL: https://github.com/apache/trafficserver/pull/8651#discussion_r801785943
##########
File path: plugins/experimental/parent_select/consistenthash_config.cc
##########
@@ -44,6 +45,19 @@
#include "consistenthash_config.h"
+namespace
+{
+std::mutex strategies_cache_mutex;
Review comment:
I don't think you need this mutex. Loading is done in a single thread. Reloading is done in a single thread. I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] rob05c merged pull request #8651: Add parent_select plugin strategy caching
Posted by GitBox <gi...@apache.org>.
rob05c merged pull request #8651:
URL: https://github.com/apache/trafficserver/pull/8651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8651: Add parent_select plugin strategy caching
Posted by GitBox <gi...@apache.org>.
zwoop commented on pull request #8651:
URL: https://github.com/apache/trafficserver/pull/8651#issuecomment-1042424847
Cherry-picked to v9.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on pull request #8651: Add parent_select plugin strategy caching
Posted by GitBox <gi...@apache.org>.
bryancall commented on pull request #8651:
URL: https://github.com/apache/trafficserver/pull/8651#issuecomment-1032073499
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] rob05c commented on a change in pull request #8651: Add parent_select plugin strategy caching
Posted by GitBox <gi...@apache.org>.
rob05c commented on a change in pull request #8651:
URL: https://github.com/apache/trafficserver/pull/8651#discussion_r801935022
##########
File path: plugins/experimental/parent_select/consistenthash_config.cc
##########
@@ -44,6 +45,19 @@
#include "consistenthash_config.h"
+namespace
+{
+std::mutex strategies_cache_mutex;
Review comment:
I wasn't sure. I can remove, if anyone can confirm it's guaranteed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org