XML parsing/writing in libsvn_wc

[Malcolm Rowe <ma...@farside.org.uk>]

On Tue, Mar 20, 2007 at 04:07:34AM -0700, Karl Fogel wrote:
> > - (This isn't exclusive to sparse-directories: changelist and keep-local
> >   do it too, but:)  Why are we writing out the depth attribute in the
> >   old XML-format entries, when by definition it can never have any value
> >   other than the default? (Also note that the specification for the
> >   entries XML format prohibits unknown attributes, so this is
> >   technically wrong).
> 
> Hmmm, good point.  Undone in r23931.
> 

Looking at this a little harder, I see that svn_wc__atts_to_entry() is
also used for parsing the logs produced by svn_wc__loggy_entry_modify(),
and so changelist, keep-local, and depth should probably all be included
in both.

However, I see that none of them are in svn_wc__loggy_entry_modify(),
which makes me wonder how they're being updated anyway.

I _think_ that 'depth' should be added back as an attribute, parsed in
svn_wc__atts_to_entry(), _not_ added to write_xml_entry(), and somehow
modified via svn_wc__loggy_entry_modify().  Changelist and keep-local
also should be modified via svn_wc__loggy_entry_modify().

Can someone who has a better idea how libsvn_wc works confirm whether
I'm talking rubbish or not?

Regards,
Malcolm
"Help, libsvn_wc is a big steamy mess".

Re: XML parsing/writing in libsvn_wc

[Ivan Zhakov <ch...@gmail.com>]

On 3/22/07, Malcolm Rowe <ma...@farside.org.uk> wrote:
> On Tue, Mar 20, 2007 at 04:07:34AM -0700, Karl Fogel wrote:
> > > - (This isn't exclusive to sparse-directories: changelist and keep-local
> > >   do it too, but:)  Why are we writing out the depth attribute in the
> > >   old XML-format entries, when by definition it can never have any value
> > >   other than the default? (Also note that the specification for the
> > >   entries XML format prohibits unknown attributes, so this is
> > >   technically wrong).
> >
> > Hmmm, good point.  Undone in r23931.
> >
>
> Looking at this a little harder, I see that svn_wc__atts_to_entry() is
> also used for parsing the logs produced by svn_wc__loggy_entry_modify(),
> and so changelist, keep-local, and depth should probably all be included
> in both.
>
> However, I see that none of them are in svn_wc__loggy_entry_modify(),
> which makes me wonder how they're being updated anyway.
>
> I _think_ that 'depth' should be added back as an attribute, parsed in
> svn_wc__atts_to_entry(), _not_ added to write_xml_entry(), and somehow
> modified via svn_wc__loggy_entry_modify().  Changelist and keep-local
> also should be modified via svn_wc__loggy_entry_modify().
>
> Can someone who has a better idea how libsvn_wc works confirm whether
> I'm talking rubbish or not?
Yes, you are right. svn_wc__atts_to_entry should updated every time
when we add new fields.

We urgently need test suite for libsvn_wc! May be it could SoC task?

>
> Regards,
> Malcolm
> "Help, libsvn_wc is a big steamy mess".
>
>


-- 
Ivan Zhakov

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org