You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2017/03/23 07:29:06 UTC
[GitHub] zeppelin pull request #2180: [gh-pages][ZEPPELIN-2303] Fix lately published ...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2180
[gh-pages][ZEPPELIN-2303] Fix lately published package ordering
### What is this PR for?
I added pagination under Helium package list in https://zeppelin.apache.org/helium_packages.html by #2126. But after this, "Lately published" page doesn't show actual latest package first. It's because while i'm paginating the packages, I should've made ordering by `published` date first before [slicing package array](https://github.com/apache/zeppelin/compare/gh-pages...AhyoungRyu:ZEPPELIN-2303/fixLatelyPublishedOrdering?expand=1#diff-c2c3af7bcb6c1faa231eaf25c15d3732R63). This PR will fix it.
### What type of PR is it?
Bug Fix | gh-pages
### What is the Jira issue?
[ZEPPELIN-2303](https://issues.apache.org/jira/browse/ZEPPELIN-2303)
### How should this be tested?
Run the website(`gh-pages`) locally as described in [here](https://github.com/apache/zeppelin/tree/gh-pages#run-website) and compare the ordering like below.
```
1. "zeppelin-sigma-spell" : "2017-03-10T09:31:56.802Z"
2. "zeppelin-d3-spell" : "2017-03-08T10:08:51.022Z"
3. "zeppelin-markdown-spell" : "2017-03-07T19:17:35.975Z"
4. "zeppelin-echo-spell" : "2017-03-07T11:37:44.283Z"
5. "zeppelin-csv-spell" : "2017-02-28T04:57:05.463Z"
6. "zeppelin-json-spell" : "2017-02-28T04:49:27.897Z"
7. "zeppelin-highcharts-heatmap" : "2017-02-14T12:46:02.732Z"
...
Last. "zeppelin-bubblechart" : "2017-01-23T20:42:34.373Z"
```
tl;dr **"zeppelin-sigma-spell"** should be the first & **"zeppelin-bubblechart"** should be the last
### Screenshots (if appropriate)
- Before
- After
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-2303/fixLatelyPublishedOrdering
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2180.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2180
----
commit 966afb243ea91e2da0c70da2c76040a74d09bfb1
Author: RyuAhyoung <ah...@macbook-pro-5.local>
Date: 2017-03-23T07:06:10Z
Fix lately published package ordering
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2180: [gh-pages][ZEPPELIN-2303] Fix lately published package...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2180
CI failure is not related with this change since it's based on `gh-pages` branch.
Merge into `gh-pages` if there are no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2180: [gh-pages][ZEPPELIN-2303] Fix lately published package...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2180
@sravan-s Thanks for the suggestion. Addressed in 34dfec8a41a0e998fcc8c030860a6c796d11df86 :)
<img width="236" alt="screen shot 2017-03-23 at 6 33 06 pm" src="https://cloud.githubusercontent.com/assets/10060731/24241202/5cdc7386-0ff7-11e7-91ed-4d1dd2089695.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2180: [gh-pages][ZEPPELIN-2303] Fix lately published package...
Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s commented on the issue:
https://github.com/apache/zeppelin/pull/2180
Hi, I guess calling it 'recently published' instead of 'lately published' is a better slang
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2180: [gh-pages][ZEPPELIN-2303] Fix lately published ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2180
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---